From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104910 invoked by alias); 10 Jul 2018 04:22:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104901 invoked by uid 89); 10 Jul 2018 04:22:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 04:22:14 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1634F1E08D; Tue, 10 Jul 2018 00:22:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531196533; bh=76tXFjrxL16ceqYslIWO3D8UbK1XKvFw/x79i/804G4=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Teh64t+XW/xsWaILhOqA3O1ga+XXWS9GMY4QDad/UMKAg0wfsDiLEmY3UkeudO+y4 VcadvlD5g5KS0q+6YguNqnoRdCqGfsakFe5y99bthQFpYAeKz8itU/qOz20InqeBvy IaVn6skONKQRSs42ZCsXLOQbT/7zjTVUkcp11dwM= Subject: Re: [RFA 38/42] Introduce legacy-buildsym.h To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-39-tom@tromey.com> From: Simon Marchi Message-ID: <89126236-88df-d625-63f9-6cfac82b44a7@simark.ca> Date: Tue, 10 Jul 2018 04:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-39-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00256.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > This introduces a new header, legacy-buildsym.h, and changes all the > symbol readers to use it. The idea is to put the function-based > interface, that relies on the buildsym_compunit global, into a > separate header. Then when a symbol reader is updated to use the new > interface, it can simply not include legacy-buildsym.h, so it's easy > to be sure that the new API is used everywhere. Cool, good idea. I have two suggestions: - Name it buildsym-legacy.h, so that it will be ordered right next to buildsym.h in alphabetical lists. - I would also create buildsym-legacy.c and move all the corresponding definitions there, including the buildsym_compunit global variable. I haven't actually tried it, maybe it's not possible and you have already tried it though. Simon