From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33981 invoked by alias); 22 May 2019 09:49:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33973 invoked by uid 89); 22 May 2019 09:49:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=confirms X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 May 2019 09:49:48 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 78106AF10; Wed, 22 May 2019 09:49:46 +0000 (UTC) Subject: Re: buildbot config cc-with-index not functional To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org References: <20190503105847.GA9448@delia> <4f515dbf-69ad-1bf0-d16b-f9bc7150e6c8@suse.de> <87k1f7nwvc.fsf@redhat.com> <3af2889a-4c04-ba8d-1c66-d2a1b1e73307@suse.de> <87ef5fntz3.fsf@redhat.com> <59ec2c21-b07b-beca-5654-74f29f6249d6@suse.de> <871s0ru17t.fsf@redhat.com> From: Tom de Vries Message-ID: <88f2db5f-7130-782c-c679-329b4a8e12fb@suse.de> Date: Wed, 22 May 2019 09:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <871s0ru17t.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00485.txt.bz2 On 21-05-19 20:11, Sergio Durigan Junior wrote: > On Monday, May 13 2019, Tom de Vries wrote: > >> On 03-05-19 22:50, Sergio Durigan Junior wrote: >>> On Friday, May 03 2019, Tom de Vries wrote: >>> >>>> On 03-05-19 21:47, Sergio Durigan Junior wrote: >>>>> On Friday, May 03 2019, Tom de Vries wrote: >>>>> >>>>>> [ was: Re: [committed][gdb/testsuite] Add cc-with-gdb-index.exp ] >>>>>> >>>>>> Hi, >>>>>> >>>>>> I've just added a target board cc-with-gdb-index.exp, to make it easy to >>>>>> test using cc-with-tweaks.sh -i. >>>>>> >>>>>> Then I stumbled upon the build bot config Fedora-x86_64-cc-with-index, >>>>>> and I took a look at the test results. >>>>>> >>>>>> I noticed that a test failing with cc-with-gdb-index.exp, >>>>>> gdb.base/cache-index.exp (see PR24516 - "cc-with-gdb-index failures") is >>>>>> passing in the cc-with-index config. >>>>>> >>>>>> I managed to reproduce that pass using the way the config uses >>>>>> cc-with-tweaks.sh: >>>>>> ... >>>>>> $ make -k check \ >>>>>> 'CC_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i gcc' \ >>>>>> 'CXX_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i g++' \ >>>>>> -j4 \ >>>>>> FORCE_PARALLEL=1 \ >>>>>> TS=1 >>>>>> ... >>>>>> >>>>>> So, AFAIU, the cc-with-index buildbot config does not actually test >>>>>> using cc-with-tweaks.sh -i, as it intends to. >>>>> >>>>> Ah... Thanks for bringing this up. IIUC, CC_FOR_TARGET and >>>>> CXX_FOR_TARGET need to be passed inside RUNTESTFLAGS. I think that's >>>>> the problem. Can you please check if you can reproduce the bug when you >>>>> do that? >>>>> >>>> >>>> Confirmed, using: >>>> ... >>>> $ make -k check "RUNTESTFLAGS='CC_FOR_TARGET=/bin/sh >>>> $pwd/gdb/contrib/cc-with-tweaks.sh -i gcc' 'CXX_FOR_TARGET=/bin/sh >>>> $pwd/gdb/contrib/cc-with-tweaks.sh -i g++' gdb.base/index-cache.exp" >>>> ... >>>> I can reproduce the bug. >>> >>> Thanks. >>> >>>>> Also, I'm happy to know there's now a cc-with-gdb-index.exp flag. So the >>>>> buildbot can just use RUNTESTFLAGS='--target_board >>>>> cc-with-gdb-index.exp', right? >>>>> >>>> >>>> Yep, that's the idea. >>> >>> Thanks, I'll update the config file now. >>> >> >> Hi, >> >> things still seem to be failing ( >> https://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/12689/steps/test%20gdb/logs/stdio >> ): >> ... >> make -k check 'RUNTESTFLAGS=CC_FOR_TARGET="/bin/sh >> /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-cc-with-index/binutils-gdb/gdb/contrib/cc-with-tweaks.sh >> -i gcc" CXX_FOR_TARGET="/bin/sh >> /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-cc-with-index/binutils-gdb/gdb/contrib/cc-with-tweaks.sh >> -i g++"' -j4 FORCE_PARALLEL=1 TS=1 >> ... >> make[1]: *** No rule to make target 'gcc CXX_FOR_TARGET=/bin/sh'. >> make[1]: *** No rule to make target 'g++'. >> ... >> ? > > Sorry, it's taken longer than I expected to get back to this, and then I > had to struggle with quoting and argument-passing. [ FWIW, I think it would have been easier to use the cc-with-gdb-index target board. ] > Anyway, I think I > figured it out now. Here's an example of the log file generated: > > https://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/e6/e6f65e7573a317ac4efff26fe0e49fe1b9e7a596/gdb.log.xz > > I'm still seeing a lot of "ERROR" messages, though: > > https://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/12827/steps/test%20gdb/logs/stdio > > I don't know if that's something related to the buildslave, or to > something else. > I cannot make too much sense out of it, with the parallel check weaving output. Perhaps it would be easier to understand these ERRORs with make -O. > Anyway, can you double check to see if I didn't forget something, > please? A test that is passing in normal testing, but is failing with cc-with-gdb-index target board, is gdb.dwarf2/main-subprogram.exp (PR24549). And I found that error in the logs, so I think that confirms that you got it working. Thanks, - Tom