From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42018 invoked by alias); 17 Jun 2017 08:03:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36122 invoked by uid 89); 17 Jun 2017 08:01:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 17 Jun 2017 08:01:42 +0000 Received: by simark.ca (Postfix, from userid 33) id D38AB1E4B1; Sat, 17 Jun 2017 04:01:25 -0400 (EDT) To: Sergio Durigan Junior Subject: Re: [PATCH] Use getenv instead of gdb_environ on mi-cmd-env.c X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 17 Jun 2017 08:03:00 -0000 From: Simon Marchi Cc: GDB Patches , Pedro Alves In-Reply-To: <20170616221231.11852-1-sergiodj@redhat.com> References: <20170616221231.11852-1-sergiodj@redhat.com> Message-ID: <88e26ea4479a02c36d195d9f9e288eb0@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00473.txt.bz2 On 2017-06-17 00:12, Sergio Durigan Junior wrote: > This is a spinoff of > . > mi-cmd-env.c is using the whole gdb_environ machinery in order to > access just one variable, which can be easily replaced by a simple > call to getenv. This patch does that, and doesn't cause regressions. > > gdb/ChangeLog: > 2017-06-16 Sergio Durigan Junior > > * mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of > gdb_environ to access an environment variable. > --- > gdb/ChangeLog | 5 +++++ > gdb/mi/mi-cmd-env.c | 12 ++++-------- > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 9062067..f5bf474 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2017-06-16 Sergio Durigan Junior > + > + * mi/mi-cm-env.c (_initialize_mi_cmd_env): Use getenv instead of > + gdb_environ to access an environment variable. > + > 2017-06-16 Alan Hayward > Pedro Alves > Yao Qi > diff --git a/gdb/mi/mi-cmd-env.c b/gdb/mi/mi-cmd-env.c > index 4093178..97be139 100644 > --- a/gdb/mi/mi-cmd-env.c > +++ b/gdb/mi/mi-cmd-env.c > @@ -270,21 +270,17 @@ mi_cmd_inferior_tty_show (const char *command, > char **argv, int argc) > void > _initialize_mi_cmd_env (void) > { > - struct gdb_environ *environment; > const char *env; > > /* We want original execution path to reset to, if desired later. > At this point, current inferior is not created, so cannot use > - current_inferior ()->environment. Also, there's no obvious > - place where this code can be moved such that it surely run > - before any code possibly mangles original PATH. */ > - environment = make_environ (); > - init_environ (environment); > - env = get_in_environ (environment, path_var_name); > + current_inferior ()->environment. We use getenv here because it > + is not necessary to create a whole new gdb_environ just for one > + variable. */ > + env = getenv (path_var_name); > > /* Can be null if path is not set. */ > if (!env) > env = ""; > orig_path = xstrdup (env); > - free_environ (environment); > } LGTM.