From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42559 invoked by alias); 13 Oct 2016 22:07:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42539 invoked by uid 89); 13 Oct 2016 22:07:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1035, aligning X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Oct 2016 22:07:03 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E367C05490F; Thu, 13 Oct 2016 22:07:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9DM71MI008854; Thu, 13 Oct 2016 18:07:01 -0400 Subject: Re: [RFA v2 02/17] Use scoped_restore for ui_file To: Tom Tromey , gdb-patches@sourceware.org References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-3-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <88d4c1e5-170d-a981-ba8b-484b447613e6@redhat.com> Date: Thu, 13 Oct 2016 22:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1476393012-29987-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00411.txt.bz2 This is OK. Please push. On 10/13/2016 10:09 PM, Tom Tromey wrote: > + scoped_restore save_stdout = make_scoped_restore (&gdb_stdout, str_file); > + scoped_restore save_stderr = make_scoped_restore (&gdb_stderr, str_file); > + scoped_restore save_stdlog = make_scoped_restore (&gdb_stdlog, str_file); > + scoped_restore save_stdtarg = make_scoped_restore (&gdb_stdtarg, str_file); > + scoped_restore save_stdtargerr = make_scoped_restore (&gdb_stdtargerr, > + str_file); > I wonder if aligning like: scoped_restore save_stdout = make_scoped_restore (&gdb_stdout, str_file); scoped_restore save_stderr = make_scoped_restore (&gdb_stderr, str_file); scoped_restore save_stdlog = make_scoped_restore (&gdb_stdlog, str_file); scoped_restore save_stdtarg = make_scoped_restore (&gdb_stdtarg, str_file); scoped_restore save_stdtargerr = make_scoped_restore (&gdb_stdtargerr, str_file); would read better. Can't tell on the mail client. Up to you; just a thought. Thanks, Pedro Alves