From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mbzdHatsMWqAbAoAWB0awg (envelope-from ) for ; Tue, 16 Jun 2026 11:32:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6BE251E098; Tue, 16 Jun 2026 11:32:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1F5821E070 for ; Tue, 16 Jun 2026 11:32:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2CD648F6647 for ; Tue, 16 Jun 2026 15:32:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2CD648F6647 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id EDD0B48FDCBE for ; Tue, 16 Jun 2026 15:32:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDD0B48FDCBE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDD0B48FDCBE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781623950; cv=none; b=xC4V3lvKfyHD1fMPnYvpXtDUkKVuwZ20cwOF/NnytBZT5H4yNVjgCGcEBlVeSBJ7QoXrPrnliaWzuNgbyi3j9jqsn5+2RI3PkMTUChqkTh+PZWYMcQny3aXeC5+jYfiVBX/XEYrqSZZ3Z3GzYbZeemNCyJ7eOkqqZXsL8A45klI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781623950; c=relaxed/simple; bh=jkfZRUP777N+XHMeBOPm7WUpjYr/dfAl/Ok1PnqpYy0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=U9/Qw4b33fvBh/shKCd9fULWw13+ySvZqdtPcavjHHlbrDAtzqDySJSEDVNR3SpmXLnN9Df3IiIHiosKkUbUd7UVneoxiSil38aniTqR/E2KnbsxGbUhegXRI7BbEo8MC0+7lS9Ry8PyEBm5l76IvF9TwrkXfDYmGKNjcHrYhjQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yBbV0DBY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=kWqSgXoa DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDD0B48FDCBE Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8DB1275AFB; Tue, 16 Jun 2026 15:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781623948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91bbpAJx7HwaxjKORX4IdTFV94ljcy8o+VFwd5OX3bk=; b=yBbV0DBYWj2nmUtvP5mEBnCR1JiJTn8MAgFGp3IkqstUBOODVl8WAwnE8++VXOT6cvXBvN 2KDyJ9IxF0/zHWa73mUbbHWMxaSqRp2WYw3zUmsUR21vFR5Q6dZpfahTGRkiImNCt/BjtZ 98g6oSjl38GKr2PuqZk6HiQSZUnx9ik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781623948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91bbpAJx7HwaxjKORX4IdTFV94ljcy8o+VFwd5OX3bk=; b=kWqSgXoa4YJkSj8NUeNqa4Xv1MRX7kQ1GhV0++hL1Tn4JGSFTX8BpRyxPFTHY9aWWAaQhd Lp0d7eGFK1C3WQBg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781623948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91bbpAJx7HwaxjKORX4IdTFV94ljcy8o+VFwd5OX3bk=; b=yBbV0DBYWj2nmUtvP5mEBnCR1JiJTn8MAgFGp3IkqstUBOODVl8WAwnE8++VXOT6cvXBvN 2KDyJ9IxF0/zHWa73mUbbHWMxaSqRp2WYw3zUmsUR21vFR5Q6dZpfahTGRkiImNCt/BjtZ 98g6oSjl38GKr2PuqZk6HiQSZUnx9ik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781623948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91bbpAJx7HwaxjKORX4IdTFV94ljcy8o+VFwd5OX3bk=; b=kWqSgXoa4YJkSj8NUeNqa4Xv1MRX7kQ1GhV0++hL1Tn4JGSFTX8BpRyxPFTHY9aWWAaQhd Lp0d7eGFK1C3WQBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7352D779A8; Tue, 16 Jun 2026 15:32:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6aH3GYxsMWrGKwAAD6G6ig (envelope-from ); Tue, 16 Jun 2026 15:32:28 +0000 Message-ID: <88bdbbf9-7ff3-4eb6-832a-1df7c785458f@suse.de> Date: Tue, 16 Jun 2026 17:32:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] Stop using deprecated language script To: Simon Marchi , gdb-patches@sourceware.org References: <20260616092346.3242305-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/16/26 3:46 PM, Simon Marchi wrote: > On 6/16/26 5:23 AM, Tom de Vries wrote: >> In v4.4.0, pre-commit renamed language script to unsupported_script. >> >> The rename was done to stress that pre-commit doesn't provide an environment >> for the script to run in [1]. >> >> The language script is now a deprecated alias for unsupported_script, and the >> plan seems to be to initially produce a deprecation warning, and eventually >> remove support for the alias completely. >> >> Start using the new name: unsupported_script. >> >> Furthermore, the check-include-guards hook uses language python, and indeed it >> uses a python script, but it doesn't really need a virtual environment. It >> imports modules fnmatch, re, sys and typing, all of which are available in >> python 3.10 and later, which is the environment pre-commit itself requires >> (because we require pre-commit v4.5.1 or later, and pre-commit requires python >> 3.10 since v4.4.0). So while we're at it, use unsupported_script for this >> hook as well, reducing the amount of environments pre-commit has to manage. >> >> Tested using "pre-commit run --all-files" with python 3.10, as well as 3.13. >> >> [1] https://github.com/pre-commit/pre-commit/pull/3577 > > From reading the pre-commit doc, I didn't understand the difference > between "unsupported_script" and "unsupported", did you? Not really. The difference seems to be that for unsupported_script "the entry should be a path relative to the root of the hook repository". Concretely, a hook like this using unsupported_script works: ... - id: bla name: bla language: unsupported entry: sh -c "echo bla; exit 1" ... Changing the language to unsupported_script gets us: "Executable `/data/vries/gdb/binutils-gdb.git/sh"` not found. To get the same effect, we need: ... - id: bla name: bla language: unsupported_script entry: /usr/bin/sh -c "echo bla; exit 1" ... Note that this version also works fine with language unsupported. The intent seems to be that unsupported_script is reserved for in-repo scripts, and unsupported is the fallback that supports anything else. Thanks, - Tom