From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fr8QBhbLjWpF+j8AWB0awg (envelope-from ) for ; Tue, 25 Aug 2026 13:04:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M+v4F31W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ADB831E0A3; Tue, 25 Aug 2026 13:04:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 449E71E033 for ; Tue, 25 Aug 2026 13:04:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 64F9C4BA7983 for ; Tue, 25 Aug 2026 17:04:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 64F9C4BA7983 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M+v4F31W Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1D4254BA2E2D for ; Tue, 25 Aug 2026 17:03:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D4254BA2E2D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D4254BA2E2D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787677434; cv=none; b=Y7oS9L0twqRw5uiyc611SbCj89dNFMsT8cVQlXFPSd9MHHwxT6r910W6SRTJrM5AauEjyeqdWp5dNyRSk78kz3dadHTo2YSURwP8mhQRx8J2FRm2lKM3jmTL3jMnbO6s/b5SrC//1Cx7eKjOd+ARwAUGZXfaSyA5tI8mS5Gs6mY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787677434; c=relaxed/simple; bh=YSgWkRUbw1vyBMZxZn3shxRxS1VVpTELqAr/KRlAqz0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RJiti/dFFo816mEWzw+OaP2Nh+e5UAOoR15teOs1p0f0S615NnsD9ADQbi/8zU4H+1DXe+zkE9UZbIxgBeittx0G1mzbSH4P/MeTa5YWMObYQ+3kVEce/z08Zm7HsjOmZz8d4J7Jev5G7NCQfp6AWzvLOIm2DHGwVW97TDhy3/Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M+v4F31W DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D4254BA2E2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787677433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AkYv3GUimXROJJ7Sj4ijfZB71XR9qPhtXyOHnd8ucCo=; b=M+v4F31WsnvmwOqKExNYob8LMrWuaKMGEE0U+sy0LTxjCRKSND2R3THe2JlmpWzlHL3PIy qS01fNryfXS2ff+MTZoRl8DhOhQuTxvi/ir6H6ojbg+NFvo3xYPCudfwV155pFrPjimb/Q 8QM2bYhmCuKkgz1ytC70WgArsJXpeQs= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-ZampzXQ1MH2A5PVSbA8hoA-1; Tue, 25 Aug 2026 13:03:50 -0400 X-MC-Unique: ZampzXQ1MH2A5PVSbA8hoA-1 X-Mimecast-MFC-AGG-ID: ZampzXQ1MH2A5PVSbA8hoA_1787677429 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7ec5495f105so6557004a34.3 for ; Tue, 25 Aug 2026 10:03:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787677429; x=1788282229; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AkYv3GUimXROJJ7Sj4ijfZB71XR9qPhtXyOHnd8ucCo=; b=dfTf96ZNATzYuZ5JIxj8ztOndz+8a5ebVf3LdMxV5JO1ezF6wAwcjSUbeiPa0mXfbL XLmHgj8/qJ9zJFkVj1gm5s1mXRZD6khRH5MngV3fo6WxgkDDi37PwsY4NDUuYo0tFCpg MkQMqHwppCB03sCG4U/94l2u0WwunZC1wlBzh/tu4egzekkzLetzeAzKPvCTib1aAv7K Qptrv0xb38mrJegmiW3RugZcrIISaTjw2/6KyA+xL1VtUn9c/L7t3hPXLMrgC4A4rmNv nu81XM9QAlPHzHW55O/sVMNDFxl85wJiAuFi/rjyz2jn7IVipfCaSr615zbobL28Gn6f 8ObA== X-Forwarded-Encrypted: i=1; AHgh+Rr4yc5A79zMM43PtqvYQ6DcUJyXOR/xt0dCmASKrtE/QymKoqNOWzOOqNShhh2QifQB9hR+FDpX4BzQpQ==@sourceware.org X-Gm-Message-State: AFuF++kn5cBf7t9pi0pkTE5fBNa+3iIeWQnI8LuJb2pEc8CcHkFpuxq7 iHZitI8KgPazZzNjSbyytc+QiZNLkShPTqjz4e4YYc+o01wbtD4ZafmF6tCEmL3KfkwpE6l2Jdh WtABvVqUVkQIeChJJsAc1CVVGh+NFSdeJCXrnPigRMQIsdCxEQVGZn+XFN3K1SFFPKK/Ynzg= X-Gm-Gg: AR+sD104vIT/NuQVwDeOjhU3D3slTk8gYQ1zVIXZstSBQ0cMhmFvi34Y+MZdbj3I7HA pw2wTWLDD0TRYIiIwrugsHbVzqO5IhR4+eetTROlmEp2HvB/YhrPHFMUsa4RjaTID41T8MU4Hw0 Yc460jHAimOLh55IMFbNx/jal06RuHqKCX1xuQQVx4J64x68h3Brlg/c/g8gh6w8keXXt2z2Gnm RIcuZCAlt6X+I0QfDaqWRAWnyHodQY7xTg6ckShlOTYK/l6LxLLlL6o4YtI250W8nMVzR2tzmD8 Fnrrbb+vbDsKk87s8zHtScxIomQ1afxezNcqiodMo/yuE8IWLsMzQkvPdsMBh7KlJbhpFB9rhej LnSD4OA== X-Received: by 2002:a05:6830:6ac3:b0:7e9:ff97:5e3b with SMTP id 46e09a7af769-7f4af9c9848mr8549693a34.15.1787677429338; Tue, 25 Aug 2026 10:03:49 -0700 (PDT) X-Received: by 2002:a05:6830:6ac3:b0:7e9:ff97:5e3b with SMTP id 46e09a7af769-7f4af9c9848mr8549591a34.15.1787677428812; Tue, 25 Aug 2026 10:03:48 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.54]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f4c4210444sm90541a34.4.2026.08.25.10.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 10:03:48 -0700 (PDT) Message-ID: <885068ad-c96f-4e32-ac39-8a004b7c718f@redhat.com> Date: Tue, 25 Aug 2026 10:03:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] gdb, gdbserver: Add Intel APX register support To: "Joos, Christina" , "gdb-patches@sourceware.org" References: <20260725105335.2664219-1-christina.joos@intel.com> <20260725105335.2664219-2-christina.joos@intel.com> From: Keith Seitz In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: _LllthAwcYQRZFjkorT1vTa7BJdkeANgQjU2O6_ESKw_1787677429 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/25/26 9:11 AM, Joos, Christina wrote: > I just found a bug in this area: > https://sourceware.org/bugzilla/show_bug.cgi?id=34561 > > Assuming a fix like the one indicated in comment of the bug will be merged > before this patch I think we can add something like this on top: > > ~~~ > diff --git a/gdb/i387-tdep.c b/gdb/i387-tdep.c > index 51459c31dcc..51180714e08 100644 > --- a/gdb/i387-tdep.c > +++ b/gdb/i387-tdep.c > @@ -955,6 +955,8 @@ i387_guess_xsave_layout (uint64_t xcr0, size_t xsave_size, > Otherwise, we are not able to read xsave registers in OS generated > corefiles. */ > layout.avx_offset = 576; > + /* Intel APX can be available on CPUs with PKRU including AMX or not > + including AMX support. */ > layout.apx_offset = 960; > layout.k_offset = 1088; > layout.zmm_h_offset = 1152; > @@ -974,6 +976,7 @@ i387_guess_xsave_layout (uint64_t xcr0, size_t xsave_size, > { > /* Intel CPUs supporting AVX512. */ > layout.avx_offset = 576; > + /* Intel APX can be available on CPUs supporting AVX512. */ > layout.apx_offset = 960; > layout.k_offset = 1088; > layout.zmm_h_offset = 1152; > ~~~ > > Or do you have a different comment in mind? I am satisfied with that. Thank you. > My original plan was to post this patch once again including the fixes for Eli's > feedback + ones pointed out by me here > https://sourceware.org/pipermail/gdb-patches/2026-August/229759.html > and then wait 1-2 weeks and merge it if there is no more feedback. > Since it's only in the x86 area I think it should be fine for me to self-approve here. > > However, in the meantime this bug mentioned above popped up. > I think it makes sense to wait until this is resolved. FWIW, I think you've got a better handle on all of the issues at play than I do, so I trust you'll Do The Right Thing (TM). Keith