From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SUC7OUphsmncoSUAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 02:46:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rk5Xu9G7; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=52JG9eb5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rk5Xu9G7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=52JG9eb5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E6C2D1E08D; Thu, 12 Mar 2026 02:46:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9A8111E08D for ; Thu, 12 Mar 2026 02:46:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0C2444B92082 for ; Thu, 12 Mar 2026 06:46:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C2444B92082 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rk5Xu9G7; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=52JG9eb5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rk5Xu9G7; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=52JG9eb5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 467284BBC081 for ; Thu, 12 Mar 2026 06:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 467284BBC081 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 467284BBC081 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773297958; cv=none; b=DzejmYyY797yWKxf+QeTikJ8Te/lRlJMvjlh4U5Vvk5rXw7S1DPURffp+KfpLU/PdcaOZ633bUUiZCRKbXnm0YLTAqyEIjF8iIWf2bAcZbi+O0H2yweL8z1eowRxBelfq3YMfkQvUOHJiu+mt3ijfdn/lc8WwT2/d1P3tf+TrX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773297958; c=relaxed/simple; bh=LGROjYxrvzEUU6valNyJzYmkV0I4IRTnW5ZF6hZPCxM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=UjjlkY2A2n5ijsnNvoK4+dG7QLcHj8TwbJ2P5eaMkZpAFYyCLYcJyYQRLQqaurnV5mKKdGVh7FtwwUAJA67BYGqlUuhu4xUdf/9HbhuGPX3hDKZzW3U1NgvNclqiW2sS4ngVYz7iv6JlC8D0Qls9KO1m/FWlWMaJekgoaujMGPs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 467284BBC081 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1011D4D310; Thu, 12 Mar 2026 06:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773297957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IG0TpJ22s4coGR/U7T7A1qkEd2iMShUELSq6VvFNWP8=; b=rk5Xu9G7ifNN/pV9Wi4/insdmJBRokSFoHZuAlF4gpeM3338+1K9KQXvmQ4olYfhQa9FIZ 3pTuRwgzdyMnTjLlB5n4YFdfvXSZ3sHz/dx8ywa+WRfdnn8looHe+Ukw0u1jlf+H8on5nT WHUaXPP8kpvD0hC0TOGl5Imkt742PBo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773297957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IG0TpJ22s4coGR/U7T7A1qkEd2iMShUELSq6VvFNWP8=; b=52JG9eb5vLt/n5Muw7bNG1NiHLS8Xvg3Aj50pZlMQedGgN9Md7y/3zb6feJHe58OgFrk3Y xvtB0i+75mqBHABw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rk5Xu9G7; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=52JG9eb5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773297957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IG0TpJ22s4coGR/U7T7A1qkEd2iMShUELSq6VvFNWP8=; b=rk5Xu9G7ifNN/pV9Wi4/insdmJBRokSFoHZuAlF4gpeM3338+1K9KQXvmQ4olYfhQa9FIZ 3pTuRwgzdyMnTjLlB5n4YFdfvXSZ3sHz/dx8ywa+WRfdnn8looHe+Ukw0u1jlf+H8on5nT WHUaXPP8kpvD0hC0TOGl5Imkt742PBo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773297957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IG0TpJ22s4coGR/U7T7A1qkEd2iMShUELSq6VvFNWP8=; b=52JG9eb5vLt/n5Muw7bNG1NiHLS8Xvg3Aj50pZlMQedGgN9Md7y/3zb6feJHe58OgFrk3Y xvtB0i+75mqBHABw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E8D263FE32; Thu, 12 Mar 2026 06:45:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O4D/NiRhsmmWfAAAD6G6ig (envelope-from ); Thu, 12 Mar 2026 06:45:56 +0000 Message-ID: <88176650-0478-4a98-9401-4a27d384f3c2@suse.de> Date: Thu, 12 Mar 2026 07:45:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] [gdb/symtab] Tweak fix-up of truncated inline function block ranges From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org References: <20260302114849.1797017-1-tdevries@suse.de> <20260302114849.1797017-4-tdevries@suse.de> <875x738ybx.fsf@redhat.com> <4f490289-ad52-4aa9-b559-b6647b2de051@suse.de> <52f8de7f-62c7-4a04-919d-aedee3314b7f@suse.de> Content-Language: en-US In-Reply-To: <52f8de7f-62c7-4a04-919d-aedee3314b7f@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 1011D4D310 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/11/26 4:13 PM, Tom de Vries wrote: > On 3/11/26 2:24 PM, Tom de Vries wrote: >> On 3/10/26 5:05 PM, Andrew Burgess wrote: >>> Which is why I tried to write DWARF assembler tests to cover edge cases >>> as I found them, and I think it would be great if we could get such a >>> test to cover this fix too. >> >> Agreed. >> >>> I'm happy to help with, or even write, the >>> test, once I can reproduce the failure. >> >> My first try: >> ... >> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp b/ >> gdb/ testsuite/gdb.dwarf2/dw2-ext >> end-inline-block.exp >> index 9e4798b53f3..82d3f7e0310 100644 >> --- a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp >> +++ b/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp >> @@ -115,7 +115,7 @@ proc build_dwarf_for_contiguous_block { asm_file } { >>           DW_LNS_copy >> >>           DW_LNE_set_address main_3 >> -        line $::foo_call_line >> +        line [expr $::foo_call_line + 1] >>           DW_LNS_negate_stmt >>           DW_LNS_copy >> ... >> doesn't seem to work (in the sense of causing failure with the fix >> applied), I'll investigate a bit further to understand why. > > OK, I think this: > ... > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp b/gdb/ > testsuite/gdb.dwarf2/dw2-ext > end-inline-block.exp > index 9e4798b53f3..4a88250d927 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-extend-inline-block.exp > @@ -120,10 +120,10 @@ proc build_dwarf_for_contiguous_block { asm_file } { >          DW_LNS_copy > >          DW_LNE_set_address main_4 > +        DW_LNS_advance_line 1 >          DW_LNS_copy > >          DW_LNE_set_address main_5 > -        DW_LNS_advance_line 1 >          DW_LNS_negate_stmt >          DW_LNS_copy > ... > is the patch that represents the behavior I was seeing. > > The testcase doesn't completely pass though, I get: > ... > (gdb) PASS: $exp: contiguous block: step to second line of foo > step^M > 28        /* foo:3 */^M > (gdb) PASS: $exp: contiguous block: step to third line of foo > step^M > 37        /* main:4 */^M > (gdb) FAIL: $exp: contiguous block: set back to main > ... > so the message saying we're back in main is missing. > I've filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33981 ) with some analysis. Thanks, - Tom > Thanks, > - Tom