From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27382 invoked by alias); 16 Feb 2006 11:11:59 -0000 Received: (qmail 27361 invoked by uid 22791); 16 Feb 2006 11:11:57 -0000 X-Spam-Check-By: sourceware.org Received: from jess.glam.ac.uk (HELO jess.glam.ac.uk) (193.63.147.97) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Feb 2006 11:11:55 +0000 Received: from mailserv1.isd.glam.ac.uk ([192.168.244.1]) by jess.glam.ac.uk with esmtp (Exim 3.35 #1) id 1F9gu4-0003wm-00; Thu, 16 Feb 2006 11:02:28 +0000 Received: from j228-gm.comp.glam.ac.uk ([193.63.148.84]) by MAILSERV1.isd.glam.ac.uk with Microsoft SMTPSVC(6.0.3790.211); Thu, 16 Feb 2006 11:11:52 +0000 Received: from gaius by j228-gm.comp.glam.ac.uk with local (Exim 4.60) (envelope-from ) id 1F9h2l-0002W7-Ft; Thu, 16 Feb 2006 11:11:27 +0000 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: Enhanced language support for Modula-2 References: <87vevg9puv.fsf@j228-gm.comp.glam.ac.uk> From: Gaius Mulley Date: Thu, 16 Feb 2006 11:11:00 -0000 In-Reply-To: Message-ID: <87zmkr5zj4.fsf@j228-gm.comp.glam.ac.uk> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-02/txt/msg00325.txt.bz2 Eli Zaretskii writes: > > From: Gaius Mulley > > Date: 15 Feb 2006 23:14:32 +0000 > > > > Anyhow this patch provides better support for Modula-2 in the > > following areas: > > > > * basic types are printed correctly when -gdwarf-2 is specified > > on the gm2 command line. > > * set types are supported (type printing and value printing). > > The patch correctly identifies: SET OF CHAR, SET OF ['a'..'z'] > > etc. > > * long and short (word length) sets are supported. > > * range types are also identified and `ptype' prints them correctly. > > * automatic detection of Modula-2 generated executable is enabled. > > * VAR parameters are printed correctly > > * hexadecimal addresses are written using the Modula-2 syntax. > > * character constants are written using the octal syntax > > (in the same way as PIM-[234].) > > Thanks. > > I think some of these changes might need updates in the user's manual. > Could you please look at the "Modula-2" section and its subsections, > and see if anything there should be added/removed/modified? yes sure.. > > + error ("type not handled in m2_type_print_varspec_prefix()"); > > User messages should be in _(), to allow for translations into other > languages. ok thanks for these pointers.. > > + fprintf_filtered(stream, "SET OF "); > > "SET OF" probably won't be translated, but "" should, so this > message should be in _() as well. true, I'll improve the patches and repost, Gaius