From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21976 invoked by alias); 29 Feb 2012 19:08:08 -0000 Received: (qmail 21959 invoked by uid 22791); 29 Feb 2012 19:08:07 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 19:07:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TJ7pS3029272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Feb 2012 14:07:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1TIJ91F001342; Wed, 29 Feb 2012 13:19:09 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1TIJ78L028845; Wed, 29 Feb 2012 13:19:08 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 14/14] -Wmissing-prototypes: Build with -Wmissing-prototypes by default. References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com> <20120229162127.23918.7524.stgit@hit-nxdomain.opendns.com> Date: Wed, 29 Feb 2012 19:11:00 -0000 In-Reply-To: <20120229162127.23918.7524.stgit@hit-nxdomain.opendns.com> (Pedro Alves's message of "Wed, 29 Feb 2012 16:21:27 +0000") Message-ID: <87zkc1o63o.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00727.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So I propose turning this warning flag on before we bit rot and pile Pedro> up another set of problems. Pedro> It's likely that on other hosts we will see other related build Pedro> failures, but going ahead and turning this on is the only way we will Pedro> ever get those fixed, and, any build error this causes should be quite Pedro> trivial to fix, as can be inferred from the changes in this series. I agree. I'm definitely in favor of this; and I think your series shows nicely the benefits of this switch. Tom