Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sigall.exp and friends: centralize signals list.
Date: Thu, 19 Jul 2012 17:24:00 -0000	[thread overview]
Message-ID: <87zk6vy88i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120719143526.8328.28449.stgit@brno.lan> (Pedro Alves's message	of "Thu, 19 Jul 2012 15:35:26 +0100")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> +for {set i 0;} {$i < [llength $signals]} {incr i;} {
Pedro> +    # Skip the first.
Pedro> +    if { $i == 0 } {
Pedro> +	continue
Pedro> +    }
Pedro> +
Pedro> +    set sig [lindex $signals $i]
Pedro> +    test_one_sig $sig
Pedro> +}

The ";"s aren't needed.  They're only needed in Tcl if you write
multiple statements on one line, but we don't do that anyhow, or
shouldn't, since it is bad style.

For the above I think it is more idiomatic in Tcl to write:

foreach sig $signals {
    if {$sig == "ABRT"} {
      continue
    }
   test_one_sig $sig
}

That said, I don't care if you leave it as-is.

Tom


  reply	other threads:[~2012-07-19 17:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 14:35 Pedro Alves
2012-07-19 17:24 ` Tom Tromey [this message]
2012-07-19 17:33   ` Pedro Alves
2012-07-19 19:17     ` Tom Tromey
2012-07-19 19:48       ` Pedro Alves
2012-07-19 19:58         ` Tom Tromey
2012-07-19 20:03         ` cleanup some fors in the testsuite (was: Re: [PATCH] sigall.exp and friends: centralize signals list.) Pedro Alves
2012-07-25 13:48 ` [patch] testsuite: Fix Tcl < 7.5 regression [Re: [PATCH] sigall.exp and friends: centralize signals list.] Jan Kratochvil
2012-07-25 13:51   ` Pedro Alves
2012-07-25 20:18     ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk6vy88i.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox