From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93105-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2295 invoked by alias); 25 Jul 2012 17:49:27 -0000
Received: (qmail 2284 invoked by uid 22791); 25 Jul 2012 17:49:26 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 17:48:58 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHmtHn001220	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 25 Jul 2012 13:48:56 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHmsPl001135	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 25 Jul 2012 13:48:55 -0400
From: Tom Tromey <tromey@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'gdb-patches\@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [patch] MI ignores conditions for pending breakpoints
References: <F7CE05678329534C957159168FA70DEC597936B72B@EUSAACMS0703.eamcs.ericsson.se>	<87txwypa85.fsf@fleche.redhat.com>	<F7CE05678329534C957159168FA70DEC5C24CAECC5@EUSAACMS0703.eamcs.ericsson.se>	<F7CE05678329534C957159168FA70DEC5C25002FAA@EUSAACMS0703.eamcs.ericsson.se>	<87k3xrkfgo.fsf@fleche.redhat.com>	<F7CE05678329534C957159168FA70DEC5C25003309@EUSAACMS0703.eamcs.ericsson.se>
Date: Wed, 25 Jul 2012 17:49:00 -0000
In-Reply-To: <F7CE05678329534C957159168FA70DEC5C25003309@EUSAACMS0703.eamcs.ericsson.se>	(Marc Khouzam's message of "Wed, 25 Jul 2012 13:45:00 -0400")
Message-ID: <87zk6nhgu1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00561.txt.bz2

>>>>> "Marc" == Marc Khouzam <marc.khouzam@ericsson.com> writes:

Marc> -standard_testfile mi-pending.c mi-pendshr.c
Marc> -set lib_sl [standard_output_file mi-pendshr.sl]
Marc> +set libfile "mi-pendshr"
Marc> +standard_testfile mi-pending.c $libfile.c
Marc> +set lib_sl [standard_output_file $libfile.sl]

I think it is better to leave the standard_testfile call as-is:

    standard_testfile mi-pending.c mi-pendshr.c
    set lib_sl [standard_output_file mi-pendshr.sl]

and then

Marc> +mi_gdb_test "-break-insert -f -c x==4 ${libfile}.c:pendfunc2" \

... use ${srcfile2} here instead of ${libfile}.c

Setting srcfile2 is part of the contract of standard_testfile.

Tom