From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25202 invoked by alias); 3 Aug 2012 17:35:22 -0000 Received: (qmail 25057 invoked by uid 22791); 3 Aug 2012 17:35:21 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 17:35:00 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q73HYvTx021069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 Aug 2012 13:34:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q73HYtC6029033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 3 Aug 2012 13:34:56 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 1/3] new observer command_param_changed. References: <1343992904-9375-1-git-send-email-yao@codesourcery.com> <1343992904-9375-2-git-send-email-yao@codesourcery.com> Date: Fri, 03 Aug 2012 17:35:00 -0000 In-Reply-To: <1343992904-9375-2-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 3 Aug 2012 19:21:42 +0800") Message-ID: <87zk6bnakg.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00120.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> +static struct cmd_list_element * Yao> +lookup_cmd_for_prefixlist (struct cmd_list_element **key, Yao> + struct cmd_list_element *list) It seems to me that this function relies on add_prefix_cmd being invoked before any of the sub-commands are added. But, I think this is not guaranteed by gdb's order-agnostic initialization approach. This, IIUC, is why the prefix list variables are global rather than being stored in the prefix command itself. If that is correct, then I think a different approach is needed. Yao> + if (notify_command_param_changed_p (option_changed, c)) Yao> { Yao> + char name[64]; It is better not to have a statically-sized buffer. This can easily be overrun by making new parameters from Python. Yao> + /* Assume that the number of command option is less than 6. */ Yao> + struct cmd_list_element *cmds[6]; Likewise. The rest looks good. Thanks for changing it to report all options. Tom