From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Set $trace_frame and $tracepoint on disconnect
Date: Thu, 23 Aug 2012 15:47:00 -0000 [thread overview]
Message-ID: <87zk5lpq5e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1345550573-24752-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Tue, 21 Aug 2012 20:02:53 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> The chunk for tracepoint.c is to set these variables correctly
Yao> when GDB disconnects and some small refactors in code.
Yao> Regression tested on x86_64-linux, two fails above are fixed.
Yao> OK to apply?
Looks good to me.
I read your patch and traced through the various tracepoint.c functions.
Just a side note on tracepoint.c - it seems bad to have functions named
"set_traceframe_num" and "set_traceframe_number" with different effects.
A bit of reading showed me what was going on, but the names seem
needlessly confusing.
Tom
next prev parent reply other threads:[~2012-08-23 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 12:03 Yao Qi
2012-08-23 15:47 ` Tom Tromey [this message]
2012-08-23 16:17 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk5lpq5e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox