From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15169 invoked by alias); 13 Sep 2012 20:56:45 -0000 Received: (qmail 15150 invoked by uid 22791); 13 Sep 2012 20:56:44 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Sep 2012 20:56:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8DKuQpt017318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Sep 2012 16:56:26 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8DKuOBs009016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 13 Sep 2012 16:56:25 -0400 From: Tom Tromey To: Khoo Yit Phang Cc: GDB Patches Subject: Re: [RFC] Make python/lib/gdb and submodules proper Python modules References: <87obldbom1.fsf@fleche.redhat.com> <446971D4-9F73-4CD9-B307-C22D4C079305@cs.umd.edu> Date: Thu, 13 Sep 2012 20:56:00 -0000 In-Reply-To: <446971D4-9F73-4CD9-B307-C22D4C079305@cs.umd.edu> (Khoo Yit Phang's message of "Wed, 12 Sep 2012 15:59:42 -0400") Message-ID: <87zk4t1w1z.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00255.txt.bz2 >>>>> "Yit" == Khoo Yit Phang writes: Yit> Thanks for the review. I've attached an updated patch that restores Yit> PYTHONDIR and fixes the formatting. Also, is there a particular Yit> preferred style for the Python code? Most of the code under Yit> gdb/python/lib/gdb seem to conform to PEP 8 (no tabs, 4-space indents, Yit> no space before parentheses) rather than the GNU style. So I've Yit> reformatted the "gdb" module to PEP 8 too. Yeah, I believe we agreed on following PEP 8 for the Python code. Maybe we did this after writing a chunk of the code, though, so it may not all be consistent. Your patch is ok. Thanks for doing this. Tom