From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96798-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23022 invoked by alias); 10 Dec 2012 19:54:45 -0000
Received: (qmail 23011 invoked by uid 22791); 10 Dec 2012 19:54:44 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 19:54:35 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBAJsXeC014293	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 10 Dec 2012 14:54:33 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBAJsVTQ022388	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 10 Dec 2012 14:54:32 -0500
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Pedro Alves <palves@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Hui Zhu <hui_zhu@mentor.com>
Subject: Re: [PATCH] Add fseek to ui-file
References: <CANFwon0Nv=Dk7-1kmxwjwv9zd-qoWUL18mpqH9vazRzBnkd10g@mail.gmail.com>	<87txryx36w.fsf@fleche.redhat.com>	<CANFwon31+VCzVWBvDLQedK0EGatd6XrRxaH1LbnHUtEKA91Ciw@mail.gmail.com>	<50C1BD45.9080709@redhat.com>	<CANFwon3_PB-9n9PTe-d2qTZ1Tf5GQkJnj9BWz+nMksHPGm0eZQ@mail.gmail.com>
Date: Mon, 10 Dec 2012 19:54:00 -0000
In-Reply-To: <CANFwon3_PB-9n9PTe-d2qTZ1Tf5GQkJnj9BWz+nMksHPGm0eZQ@mail.gmail.com>	(Hui Zhu's message of "Mon, 10 Dec 2012 18:47:31 +0800")
Message-ID: <87zk1lel8o.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00271.txt.bz2

>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Pedro> I think that if we want to support error handling, then this should
Pedro> return the fseek result to the caller instead of throwing an exception.
Pedro> See e.g., the comment in stdio_file_write.

I wonder whether that comment is correct.

Hui> What about I change error to warning?
Hui> Then it don't need some handle and something.  And if really got some
Hui> issue with this syscall, user can find issue with this warning?

I think that would be a worse solution.
It would mean the writing would continue even after failing.
Better to do what Pedro asks.

Tom