Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: catch SIGSEGV in the demangler
Date: Fri, 18 Jan 2013 17:34:00 -0000	[thread overview]
Message-ID: <87zk0675uy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87622vd2vd.fsf@fleche.redhat.com> (Tom Tromey's message of "Thu,	17 Jan 2013 12:29:58 -0700")

>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:

Tom> I was thinking of perhaps expanding the scope somewhat.

Tom> One idea I had was to introduce a new RETURN_SEGV to return_reason and
Tom> *not* add this to RETURN_MASK_ALL.

Tom> Then, have a special throw_segv that first looks to see if anything
Tom> expects to catch it, and if not, reset the handler and re-raise the
Tom> signal.

Tom> This way we could let code handle SEGV when appropriate, without tying
Tom> it to the demangler -- but also without catching all SEGVs that occur in
Tom> gdb.

I implemented this and I think it reads a bit better.
Now any code that knows what to do with a SEGV can

TRY_CATCH (except, RETURN_MASK_SEGV) { ... }

... but if nothing on the call stack does this, SEGVs are just allowed
to cause gdb to crash.

Tom


      parent reply	other threads:[~2013-01-18 17:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 20:15 RFC: " Tom Tromey
2013-01-16 22:16 ` Pierre Muller
     [not found] ` <19236.9665638127$1358374641@news.gmane.org>
2013-01-17 19:56   ` Tom Tromey
2013-01-18 11:22     ` Pedro Alves
2013-01-18 15:01       ` Tom Tromey
2013-01-18 15:41         ` Pedro Alves
2013-01-18 16:09           ` Tom Tromey
2013-01-18 17:56             ` Pedro Alves
2013-01-18 18:09               ` Tom Tromey
2013-01-18 16:31       ` Tom Tromey
2013-01-18 16:59         ` Pedro Alves
2013-01-18 17:34     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk0675uy.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox