Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] fix disassemble foo::bar::~bar
Date: Fri, 22 Feb 2013 20:00:00 -0000	[thread overview]
Message-ID: <87zjyw6rwk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5127CA5E.5090201@redhat.com> (Keith Seitz's message of "Fri, 22	Feb 2013 11:43:26 -0800")

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> (gdb) p foo::~bar
Keith> name of destructor must equal name of class

Keith> How much more useful is that than

Keith> (gdb) p foo::~bar
Keith> There is no field named ~bar

I think the difference is that with the current code, it is a parse-time
error, but if we remove destructor_name_p, then it is an evaluation-time
error.  This difference matters for breakpoint conditions.

Searching the type's function fields seems like the very best, to me.
I couldn't think of a drawback of this anyhow.

Tom


      reply	other threads:[~2013-02-22 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14  0:14 Doug Evans
2013-02-21 21:14 ` Tom Tromey
2013-02-21 23:58   ` Keith Seitz
2013-02-22 19:15     ` Tom Tromey
2013-02-22 19:43       ` Keith Seitz
2013-02-22 20:00         ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjyw6rwk.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox