Re: [PATCH 1/3] Add a select_frame_reason enum parameter to select_frame

Maxime Coste
2013-05-14T13:23:29Z

Hello

On Mon, 06 May 2013 17:54:01 +0100, Pedro Alves <palves@redhat.com> wrote:
> IMO, it'd be better to leave select_frame unaware of why it's being
> called, and just add a wrapper for user visible frame selection.
> It feels like different conceptual levels to me. IOW, something like:
>
> void
> select_user_frame (struct frame_info *fi)
> [...]

That seems better to me too, I went the other way because at first I tried
to add checks for frame restoration (there were IMPL_DETAIL_{PUSH,POP}
with a counter checking that only IMPL_DETAIL_* were nested...

I'll prepare a patch using this approach.

> If we limit frame change notifications to user frame changes
> (CLI up/down/frame and MI equivalents), then these issues
> with stops would be non-issues by design...

Yes, this seems more reasonable as well.

Thanks for the review.

Maxime.