From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12602 invoked by alias); 29 Apr 2013 20:24:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12592 invoked by uid 89); 29 Apr 2013 20:24:42 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 29 Apr 2013 20:24:42 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3TKOei9021811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 29 Apr 2013 16:24:40 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3TKOdZc002456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 29 Apr 2013 16:24:39 -0400 From: Tom Tromey To: Maxime Coste Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Add a frame_changed observer References: <1367002961-12311-1-git-send-email-frrrwww@gmail.com> <1367002961-12311-3-git-send-email-frrrwww@gmail.com> Date: Tue, 30 Apr 2013 10:51:00 -0000 In-Reply-To: <1367002961-12311-3-git-send-email-frrrwww@gmail.com> (Maxime Coste's message of "Fri, 26 Apr 2013 21:02:40 +0200") Message-ID: <87zjwhxeyh.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00884.txt.bz2 >>>>> "Maxime" == Maxime Coste writes: Maxime> +@deftypefun void frame_changed (struct frame_info *@var{frame}) Maxime> +the selected frame has changed; Maxime> +@end deftypefun I think this needs more text and should probably be a full sentence. Like The selected frame has changed in a user-visible way. @var{frame} is the new frame. Tom