From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12300 invoked by alias); 10 Jul 2013 16:28:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12255 invoked by uid 89); 10 Jul 2013 16:28:35 -0000 X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 10 Jul 2013 16:28:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6AGSXqB022883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Jul 2013 12:28:33 -0400 Received: from barimba (ovpn-113-131.phx2.redhat.com [10.3.113.131]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6AGSWer009636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 10 Jul 2013 12:28:32 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: Build regression on CentOS-5 [Re: [PATCH 3/3] add -Wold-style-definition] References: <1371494572-26594-1-git-send-email-tromey@redhat.com> <1371494572-26594-4-git-send-email-tromey@redhat.com> <20130702080754.GA24111@host2.jankratochvil.net> <87hagcela1.fsf@fleche.redhat.com> <87a9m4el8y.fsf@fleche.redhat.com> <20130703090018.GA1009@host2.jankratochvil.net> Date: Wed, 10 Jul 2013 16:28:00 -0000 In-Reply-To: <20130703090018.GA1009@host2.jankratochvil.net> (Jan Kratochvil's message of "Wed, 3 Jul 2013 11:00:18 +0200") Message-ID: <87zjtugz0w.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00277.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> I would find easier: s/$(ADA_EXP_C)/$ above. Or is that for non-GNU make without VPATH? But non-VPATH Jan> make would IMO fail on missing pre-requisite file ada-exp.c. Jan> I do not mind either way. I think that according to POSIX, $< is unspecified in an explicit rule. I think we ought to fully require GNU make but this patch isn't the way to decide that :) Tom