From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12390 invoked by alias); 10 Oct 2013 20:45:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12381 invoked by uid 89); 10 Oct 2013 20:45:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 20:45:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKj0lt003321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 16:45:01 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKixQC005318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 16:45:00 -0400 From: Tom Tromey To: Nicolas Blanc Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v16 5/5] Test adding and removing a symbol file at runtime. References: <1381148820-21890-1-git-send-email-nicolas.blanc@intel.com> <1381148820-21890-6-git-send-email-nicolas.blanc@intel.com> Date: Thu, 10 Oct 2013 20:45:00 -0000 In-Reply-To: <1381148820-21890-6-git-send-email-nicolas.blanc@intel.com> (Nicolas Blanc's message of "Mon, 7 Oct 2013 14:27:00 +0200") Message-ID: <87zjqg4zzo.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00369.txt.bz2 >>>>> "Nicolas" == Nicolas Blanc writes: Nicolas> 2013-04-04 Nicolas Blanc Nicolas> * gdb.base/sym-file-lib.c: New file. Nicolas> * gdb.base/sym-file-loader.c: New file. Nicolas> * gdb.base/sym-file-loader.h: New file. Nicolas> * gdb.base/sym-file-main.c: New file. Nicolas> * gdb.base/sym-file.exp: New file. Nicolas> +if [is_lp64_target] { Nicolas> + set target_size TARGET_LP64 Nicolas> +} elseif [is_ilp32_target] { Nicolas> + set target_size TARGET_ILP32 Nicolas> +} else { Nicolas> + return 0 Nicolas> +} It's slightly better to brace the expressions. Otherwise they are both evaluated first. That is: if {[is_ilp64_target]} { ... Nicolas> +set testfile sym-file.exp Nicolas> +set mainfile sym-file-main Nicolas> +set loaderfile sym-file-loader Nicolas> +set libfile sym-file-lib Nicolas> +set srcfiles "${mainfile}.c ${loaderfile}.c" Nicolas> +set libsrc "${srcdir}/${subdir}/${libfile}.c" Nicolas> +set libname "${libfile}.so" Nicolas> +set shlib_name "${objdir}/${subdir}/${libname}" Nicolas> +set libobj "${objdir}/${subdir}/${libname}" It's better to use standard_testfile and standard_output_file. That way it will work with the parallelization patch series. Nicolas> +set result [gdb_test "add-symbol-file ${shlib_name} addr" \ Nicolas> + "Reading symbols from .*${shlib_name}\\.\\.\\.done\\." \ Nicolas> + "add-symbol-file ${shlib_name} addr" \ It looks like the full file name of the shlib ends up in the test name here. It's better to use a test name that doesn't depend on the cwd, so that comparisons across different build directories don't yield spurious differences. Nicolas> +gdb_test "info files" \ Nicolas> + "^(?=(.*${libname})).*" \ Nicolas> + "info files must display $libname" Here too and presumably elsewhere. Tom