From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10494 invoked by alias); 5 Nov 2013 19:52:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10484 invoked by uid 89); 5 Nov 2013 19:52:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 19:52:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5JqJDQ004429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Nov 2013 14:52:19 -0500 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA5JqIuB028191 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 5 Nov 2013 14:52:19 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/6] introduce common.m4 References: <1383675811-3274-1-git-send-email-tromey@redhat.com> <1383675811-3274-2-git-send-email-tromey@redhat.com> <5279425C.7020201@redhat.com> Date: Tue, 05 Nov 2013 20:03:00 -0000 In-Reply-To: <5279425C.7020201@redhat.com> (Pedro Alves's message of "Tue, 05 Nov 2013 19:09:16 +0000") Message-ID: <87zjpipqx9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-11/txt/msg00100.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> HAVE_LANGINFO_CODESET is used by common/gdb_locale.h, Pedro> and GDB_AC_COMMON uses AM_LANGINFO_CODESET. Shouldn't Pedro> codeset.m4 then be included by common.m4 instead? It's also needed by gdb/charset.c, so technically it should be included in both places. However it seems strange to include the file twice, and reasonably harmless the way it is. Tom