From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2014 invoked by alias); 10 Jan 2014 21:18:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1999 invoked by uid 89); 10 Jan 2014 21:18:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 21:18:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALIRN5009811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jan 2014 16:18:27 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0ALIPxO020819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Jan 2014 16:18:26 -0500 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/5] Implement D primitive types in GDB References: <87sisx80oo.fsf@fleche.redhat.com> Date: Fri, 10 Jan 2014 21:18:00 -0000 In-Reply-To: (Iain Buclaw's message of "Fri, 10 Jan 2014 12:57:53 +0000") Message-ID: <87zjn34jtq.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00297.txt.bz2 >>>>> "Iain" == Iain Buclaw writes: Iain> Comments duly noted and rebased patch. Though I have a feeling you Iain> may ask to comment non-static functions in their declared headers. :) That's like the one thing gdb doesn't have a pedantic standard for. Yet :) At some point Stan will presumably push in his doxygen change and then we'll start converting to that. Iain> +/* Mapping of all D basic data types into the language vector. */ Iain> +enum d_primitive_types { Space between the comment and the definition. Yeah, that pedantic. Iain> + d_primitive_type_cent, /* signed 128 bit integer */ Comments have to start with an upper-case letter and end with a period and two spaces. Iain> +/* Implements the la_language_arch_info language_defn routine Iain> + for language D. */ Iain> +static void Blank line here and elsewhere. This is ok with those nits fixed. Tom