From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17745 invoked by alias); 16 Jan 2014 17:33:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17719 invoked by uid 89); 16 Jan 2014 17:33:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:33:28 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0GHXPJf022692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Jan 2014 12:33:25 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0GHXOpH011386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 16 Jan 2014 12:33:24 -0500 From: Tom Tromey To: "Agovic\, Sanimir" Cc: "palves\@redhat.com" , "xdje42\@gmail.com" , "gdb-patches\@sourceware.org" , "Boell\, Keven" Subject: Re: [PATCH v4 12/13] test: basic c99 vla tests for C primitives References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-13-git-send-email-sanimir.agovic@intel.com> <871u09orgl.fsf@fleche.redhat.com> <0377C58828D86C4588AEEC42FC3B85A7176D3671@IRSMSX105.ger.corp.intel.com> Date: Thu, 16 Jan 2014 17:33:00 -0000 In-Reply-To: <0377C58828D86C4588AEEC42FC3B85A7176D3671@IRSMSX105.ger.corp.intel.com> (Sanimir Agovic's message of "Thu, 16 Jan 2014 17:02:03 +0000") Message-ID: <87zjmvn863.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00627.txt.bz2 >>>>> "Sanimir" == Agovic, Sanimir writes: Tom> I didn't see any tests for the case where there should be a side effect. Sanimir> This line from above: Sanimir> gdb_test "print sizeof (++int_vla\[0\])" [...] Sanimir> Is used to ensure that no side effect happen to arguments Sanimir> passed to sizeof. Sanimir> The test is trying to express the following: Sanimir> int i = 42; sizeof(++i); assert (i == 42) Sanimir> Is it OK? Yeah, that's good -- but I think there are also cases where a side effect is expected, and it would be good to have a test for that as well. Tom