From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2002 invoked by alias); 31 Jul 2014 01:46:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1891 invoked by uid 89); 31 Jul 2014 01:46:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Jul 2014 01:46:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6V1kFk6005952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 21:46:15 -0400 Received: from barimba (ovpn-113-151.phx2.redhat.com [10.3.113.151]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6V1kDNW015717 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 30 Jul 2014 21:46:14 -0400 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 14/13] Move errno.h to common-defs.h References: <1406644635-1011-1-git-send-email-gbenson@redhat.com> <1406724370-20612-1-git-send-email-gbenson@redhat.com> Date: Thu, 31 Jul 2014 08:55:00 -0000 In-Reply-To: <1406724370-20612-1-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Wed, 30 Jul 2014 13:46:10 +0100") Message-ID: <87zjfqti57.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-07/txt/msg00800.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> This commit moves the inclusion of errno.h to common-defs.h and Gary> removes all other inclusions. Note that prior to this commit errno.h Gary> was included unconditionally in defs.h, whereas in common-defs.h it is Gary> protected by "#ifdef HAVE_ERRNO_H". This does not change the status Gary> quo, since presumably every platform on which GDB builds has errno.h. Gary> Is this ok to commit? Gary> * configure.ac (AC_CHECK_HEADERS): Add errno.h. If a header in common/, nat/, or target/ requires an autoconf define, then the check should be added to common/common.m4 and then the various configure scripts rebuilt. This way we ensure that gdb and gdbserver keep in sync. There were problems with this in the past. I think it's fine to unconditionally include errno.h. For one thing some files in gdb did this. Also I believe it is pulled into gnulib as a dependency of some other module; though you'd probably want to check this. If you go this route then I guess it would be nice to remove errno.h checks instead. Tom