From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32138 invoked by alias); 8 Oct 2014 19:40:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32128 invoked by uid 89); 8 Oct 2014 19:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Oct 2014 19:40:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s98JekVd017802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Oct 2014 15:40:46 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s98JekqP025685 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 8 Oct 2014 15:40:46 -0400 From: Sergio Durigan Junior To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/9] Add support for DTrace USDT probes to gdb References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> X-URL: http://blog.sergiodj.net Date: Wed, 08 Oct 2014 19:40:00 -0000 In-Reply-To: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> (Jose E. Marchesi's message of "Fri, 26 Sep 2014 11:48:16 +0200") Message-ID: <87zjd69wox.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00172.txt.bz2 On Friday, September 26 2014, Jose E. Marchesi wrote: > This patch series introduces support in GDB for a new type of probe: > DTrace USDT probes. > > The first three patches do some changes to the existing probe.[ch] > code, fixing some minor problems associated to support several probe > types, having several probes of different types defined in the same > object and supporting the notion of enabling and disabling probes. > > The rest of the patches are the implementation of the new probe type, > including target support for x86_64 targets, a testsuite and > documentation. OK, I think I reviewed all the patches (except the docs). First of all, thanks for doing this! I have mixed feelings about the inclusion of this feature. While I obviously agree that support for a new probe type is good, I also don't like the fact that we are talking about a feature that relies on proprietary software (Oracle dtrace) to operate. For example, when trying to test this here, I naively thought that using something like "dtrace4linux" () would be enough. It wasn't. So you kindly helped me with this, but I know that other people who decide to test GDB might not be lucky to have Jose helping them :-). You mentioned that you were going to try to come up with some way to test this feature using a tweaked asm source. I think this is a good progress already, and I am looking forward to seeing this. Either way, if we decide to include this feature on GDB, you (or someone else from Oracle) will be responsible for it, because we outside Oracle have no way to make sure that it doesn't break. Having said that, I will wait until you post updated patches with our comments addressed (and hopefully with a nice testcase :-P), and then we can continue this discussion :-). Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/