From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5087 invoked by alias); 12 Feb 2015 20:32:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5066 invoked by uid 89); 12 Feb 2015 20:32:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 20:32:14 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKWCuw013513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Feb 2015 15:32:13 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKWCZd006206 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 12 Feb 2015 15:32:12 -0500 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Merge dg-extract-results.{sh,py} from GCC upstream References: <1418686405-29922-1-git-send-email-sergiodj@redhat.com> <54DD0C8F.6050303@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 12 Feb 2015 20:32:00 -0000 In-Reply-To: <54DD0C8F.6050303@redhat.com> (Pedro Alves's message of "Thu, 12 Feb 2015 20:26:55 +0000") Message-ID: <87zj8idg6r.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00334.txt.bz2 On Thursday, February 12 2015, Pedro Alves wrote: >> gdb/testsuite/ChangeLog: >> 2014-12-14 Sergio Durigan Junior >> >> Merge dg-extract-results.{sh,py} from GCC upstream (r210243, >> r210637, r210913, r211666, r215400, r215817). >> >> 2014-05-08 Richard Sandiford >> * dg-extract-results.py: New file. > > Unfortunately, the Python version of this script (dg-extract-results.py) > doesn't produce stable results. The sorting changes between runs for > some reason. That may be tolerable for GCC, but for GDB, it often > renders test diffing unworkable. Sorry for not catching this before. Our BuildBot does not suffer from this because it doesn't rely on the order of the results in the .sum file... > I think we should remove dg-extract-results.py, and re-sync > dg-extract-results.sh from the gcc repo to pick up your fix for > the grep/binary issue that went in meanwhile. > > WDYT? I'm in favor. But just to be safe (sorry for repeating): we need to pick up my fix from GCC. Otherwise the BuildBot wil be badly affected. Cheers, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/