From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12357 invoked by alias); 3 Jan 2017 21:38:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12323 invoked by uid 89); 3 Jan 2017 21:38:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fine!, H*f:sk:2c08952, H*i:sk:2c08952, january X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jan 2017 21:38:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 978E988E60; Tue, 3 Jan 2017 21:38:43 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v03LcgNi002382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 3 Jan 2017 16:38:43 -0500 From: Sergio Durigan Junior To: Luis Machado Cc: GDB Patches , Subject: Re: [PATCH 2/6] Share parts of gdb/terminal.h with gdbserver References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <1482464361-4068-3-git-send-email-sergiodj@redhat.com> <8074e0e3-a026-78d7-d42b-953fd5c76ba7@codesourcery.com> <87lgurq213.fsf@redhat.com> <2c08952e-2466-6b5e-5098-95fd64d4c445@codesourcery.com> X-URL: http://blog.sergiodj.net Date: Tue, 03 Jan 2017 21:38:00 -0000 In-Reply-To: <2c08952e-2466-6b5e-5098-95fd64d4c445@codesourcery.com> (Luis Machado's message of "Tue, 3 Jan 2017 15:26:48 -0600") Message-ID: <87zij7omce.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00035.txt.bz2 On Tuesday, January 03 2017, Luis Machado wrote: >>>> +void >>>> +new_tty (void) >>>> +{ >>>> + /* To be implemented. */ >>>> +} >>>> + >>>> +/* See common/common-terminal.h. */ >>>> + >>>> +void >>>> +new_tty_prefork (const char *ttyname) >>>> +{ >>>> + /* To be implemented. */ >>>> +} >>>> + >>>> +/* See common/common-terminal.h. */ >>>> + >>>> +void >>>> +new_tty_postfork (void) >>>> +{ >>>> + /* To be implemented. */ >>>> +} >>> >>> Are these going to be implemented at some point or is this something >>> that may not be addressed until much later on? >> >> They're not exactly on my radar, but they're a part of the local/remote >> feature parity, so they will be tackled soon, I'd figure. >> >>> It wouldn't be great to have a number of these lying around with no >>> clear plan to have them addressed. >> >> I agree. >> >>> Are these counterparts of what gdb always has? Does it make sense to >>> unify those functions instead of adding placeholders for a potentially >>> different implementation? >> >> I'll try to give these a try and implementing them. My only concern is >> that I don't want these to explode into a giant new task to implement >> inferior I/O on gdbserver, but it may be possible to just touch the >> necessary bits and make it simple. >> > > The rule is that the patch sender automatically volunteers for > additional bits of work. :-P "Additional bits" it totally fine! The problem is "additional gigabytes" ;-). > Honestly, if it gets too complicated, then it should be fine to have > the placeholders. But then it would be nice to add some more > interesting comments on how these ought to be implemented in the > future, along with bits on how these should be synched with what gdb > already supports. > > Just an idea. Sure, it's a great idea indeed. Thanks for bringing this up; I'll work on this and will come back when I have more news. Thanks -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/