From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126530 invoked by alias); 9 Sep 2017 18:36:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126227 invoked by uid 89); 9 Sep 2017 18:36:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=D*ca X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 18:36:19 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id 16DE11405AF for ; Sat, 9 Sep 2017 12:36:18 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id 7WcF1w0042f2jeq01WcJ6w; Sat, 09 Sep 2017 12:36:18 -0600 X-Authority-Analysis: v=2.2 cv=K4VSJ2eI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=_ZhYKdCeAAAA:8 a=8LCErYOOoU32O6MH20wA:9 a=uqOk3ZSnBfCTOznnrPA1:22 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:41264 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dqkc2-000a3L-T4; Sat, 09 Sep 2017 12:36:14 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/7] Use ui_out_emit_table and ui_out_emit_list in print_thread_info_1 References: <20170909153540.15008-1-tom@tromey.com> <20170909153540.15008-2-tom@tromey.com> <02d471158b96dd13bd7f998f8ec2a310@polymtl.ca> Date: Sat, 09 Sep 2017 18:36:00 -0000 In-Reply-To: <02d471158b96dd13bd7f998f8ec2a310@polymtl.ca> (Simon Marchi's message of "Sat, 09 Sep 2017 19:47:04 +0200") Message-ID: <87zia3afdt.fsf@bapiya> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dqkc2-000a3L-T4 X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:41264 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00248.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I think overall this function is a bad example of how to share code Simon> between CLI and MI. There are so many if (is_mi_like_p) that it's Simon> essentially two functions in one. Apart from iterating on threads, Simon> the MI and CLI outputs don't share much... I think a long term goal should be to remove all those is_mi_like_p checks. In some situations this might mean introducing "MI 4" and fixing up the historical baggage; but that would also be a good thing, as there are a few places where gdb has remained buggy for the sake of not breaking existing MI readers. What I'd really like is for MI to be defined as JSON (it is pretty close already), but that's maybe a bit much to ask. A related thought is that if more spots used ui-out (I'm thinking mainly *-valprint, but maybe there are others), then colorization could be done at the ui-out layer. Tom