From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75127 invoked by alias); 23 Sep 2017 04:05:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75117 invoked by uid 89); 23 Sep 2017 04:05:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 04:05:39 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 0A82D1404B1 for ; Fri, 22 Sep 2017 22:05:38 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id Cs5a1w01L2f2jeq01s5duF; Fri, 22 Sep 2017 22:05:38 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=20KFwNOVAAAA:8 a=vgr1w72XYh2EXBcMX4cA:9 a=HtSy_R_nFDAA:10 Received: from 75-166-76-94.hlrn.qwest.net ([75.166.76.94]:39030 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dvbh8-002WRl-CM; Fri, 22 Sep 2017 22:05:34 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 37/67] Constify some commands in record.c References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-38-tom@tromey.com> Date: Sat, 23 Sep 2017 04:05:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 21 Sep 2017 11:00:25 +0100") Message-ID: <87zi9mgiuq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dvbh8-002WRl-CM X-Source-Sender: 75-166-76-94.hlrn.qwest.net (bapiya) [75.166.76.94]:39030 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00718.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 09/21/2017 06:09 AM, Tom Tromey wrote: >> @@ -456,13 +458,15 @@ get_context_size (char **arg) >> if (!isdigit (*pos)) >> error (_("Expected positive number, got: %s."), pos); >> >> - return strtol (pos, arg, 10); >> + long result = strtol (pos, &end, 10); >> + *arg = end; >> + return result; >> } Pedro> Indentation looks odd. [3 spaces instead of 2?] I've fixed it. Tom