From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14970 invoked by alias); 28 Sep 2017 02:04:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14672 invoked by uid 89); 28 Sep 2017 02:04:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 02:04:54 +0000 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id 5CA1414069F for ; Wed, 27 Sep 2017 20:04:53 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id Eq4q1w0022f2jeq01q4tgq; Wed, 27 Sep 2017 20:04:53 -0600 X-Authority-Analysis: v=2.2 cv=OZLoNlbY c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=2JCJgTwv5E4A:10 a=sqwsmUkd4QfJR96C2OUA:9 Received: from 75-166-0-208.hlrn.qwest.net ([75.166.0.208]:40960 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dxOC1-003Qhd-Sy; Wed, 27 Sep 2017 20:04:49 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [users/palves/catch_exceptions] [PATCH] zap catch_exceptions (Re: [RFA] Change exceptions.h functions to use gdb::function_view) References: <20170927165302.30177-1-tom@tromey.com> <4098e86f-d084-fb3b-ea9b-0d5565ddd930@redhat.com> <87o9pvyjlb.fsf@pokyo> <7262baed-d54f-4c7c-abe3-b2bd90ff9562@redhat.com> <1f40ef50-9f1f-32f0-a71a-c97c404fd66f@redhat.com> Date: Thu, 28 Sep 2017 02:04:00 -0000 In-Reply-To: <1f40ef50-9f1f-32f0-a71a-c97c404fd66f@redhat.com> (Pedro Alves's message of "Thu, 28 Sep 2017 01:01:56 +0100") Message-ID: <87zi9finni.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dxOC1-003Qhd-Sy X-Source-Sender: 75-166-0-208.hlrn.qwest.net (bapiya) [75.166.0.208]:40960 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-09/txt/msg00845.txt.bz2 Pedro> Alright, I've pushed this patch below on the branch as well. It Pedro> gets rid of catch_exceptions / catch_exceptions_with_msg. The Pedro> latter is done mostly by getting rid of the remaining vestigial libgdb Pedro> wrapper functions, which are really pointless nowadays. This results in Pedro> a good number of simplifications. Thanks for doing this. I'd started earlier, and did the catch_errors part, but I saw your mail before I finished; and I think your patch is a bit cleaner anyway. I think my MI cleanup branch (still pending review) also touched these vestigial libgdb functions, but I don't mind rebasing that when the time comes. Tom