From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129368 invoked by alias); 31 Oct 2017 01:33:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129358 invoked by uid 89); 31 Oct 2017 01:33:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=ham version=3.3.2 spammy=tab X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Oct 2017 01:33:43 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 649C4552C7; Tue, 31 Oct 2017 01:33:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 649C4552C7 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EF465D6AE; Tue, 31 Oct 2017 01:33:42 +0000 (UTC) From: Sergio Durigan Junior To: Mike Gulick Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/Makefile.in: fix 'make tags' failure References: <68f1f2bf-a5a9-d1e5-6f5a-ea9d5db3b887@mathworks.com> <874lqg9r3t.fsf@redhat.com> <0b415071-9af7-6521-8f35-c9766696c98c@mathworks.com> Date: Tue, 31 Oct 2017 01:33:00 -0000 In-Reply-To: <0b415071-9af7-6521-8f35-c9766696c98c@mathworks.com> (Mike Gulick's message of "Mon, 30 Oct 2017 20:11:52 -0400") Message-ID: <87zi8885je.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00912.txt.bz2 On Monday, October 30 2017, Mike Gulick wrote: > On 10/30/2017 07:02 PM, Sergio Durigan Junior wrote: >> On Monday, October 30 2017, Mike Gulick wrote: >> >>> 'make tags' has been broken in master for a couple of weeks. Hopefully this >>> is small enough to not require copyright attribution. Otherwise someone can >>> be "inspired" by this change to fix it themselves. >> >> Thanks for the patch, Mike. Could you please write a proper ChangeLog >> entry and a more descriptive commit message? When you do that I can >> push this in for you under the obvious rule. > > Sure, how about this: > > From e330a7a6763a4d520e2c15792154db1aaa30c86a Mon Sep 17 00:00:00 2001 > From: Mike Gulick > Date: Thu, 19 Oct 2017 16:51:33 -0400 > Subject: [PATCH] gdb/Makefile.in: fix 'make tags' failure > > 'make tags' fails with the following error: > > make[2]: Entering directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb' > make[2]: *** No rule to make target 'gdb.h', needed by 'TAGS'. Stop. > make[2]: Leaving directory '/local-ssd/mgulick/gdb/git/binutils-gdb/gdb' > > The file gdb/gdb.h was removed in commit > 65630365f7d073430e62b4fe65f34dcdc0a4b05e. > > gdb/ChangeLog: > > * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h. This should have been indented with a TAB; I fixed it in the commit log. Otherwise, looks good. I went ahead and pushed as obvious: f871c4853a9725682011c2314ea4308f3c34bd8d Thanks! > --- > gdb/ChangeLog | 4 ++++ > gdb/Makefile.in | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 5a680ed..a72cc74 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2017-10-30 Mike Gulick > + > + * Makefile.in (HFILES_NO_SRCDIR): Remove reference to gdb.h. > + > 2017-10-30 Simon Marchi > > * common/common-utils.h (in_inclusive_range): New function. > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 6cb0970..1a68746 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -1346,7 +1346,6 @@ HFILES_NO_SRCDIR = \ > frv-tdep.h \ > ft32-tdep.h \ > gcore.h \ > - gdb.h \ > gdb_bfd.h \ > gdb_curses.h \ > gdb-dlfcn.h \ > -- > 2.1.4 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/