From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88506 invoked by alias); 26 Apr 2018 20:56:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88454 invoked by uid 89); 26 Apr 2018 20:56:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=arc_type_align, ULONGEST, check_typedef, TYPE_LENGTH X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.197.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Apr 2018 20:56:30 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 4E9A2A8FA for ; Thu, 26 Apr 2018 15:56:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BnwLfzgrjQUwqBnwLfkL2G; Thu, 26 Apr 2018 15:56:29 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:59206 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fBnwL-002IkS-1j; Thu, 26 Apr 2018 15:56:29 -0500 From: Tom Tromey To: Anton Kolesov Cc: Tom Tromey , "gdb-patches\@sourceware.org" , Claudiu Zissulescu Subject: Re: [RFA 6/6] Remove long_long_align_bit gdbarch attribute References: <20180424152222.8053-1-tom@tromey.com> <20180424152222.8053-7-tom@tromey.com> <39A54937CC95F24AA2F794E2D2B66B1358A23CD3@DE02WEMBXB.internal.synopsys.com> Date: Thu, 26 Apr 2018 20:56:00 -0000 In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B1358A23CD3@DE02WEMBXB.internal.synopsys.com> (Anton Kolesov's message of "Tue, 24 Apr 2018 17:16:21 +0000") Message-ID: <87zi1p660z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fBnwL-002IkS-1j X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:59206 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00544.txt.bz2 >>>>> "Anton" == Anton Kolesov writes: Anton> I would have implemented this as: Anton> static ULONGEST Anton> arc_type_align (struct gdbarch *gdbarch, struct type *type) { Anton> type = check_typedef (type); Anton> return std::min(4, TYPE_LENGTH (type)); Anton> } Thanks, I've made this change locally. Tom