From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20659 invoked by alias); 1 Aug 2018 04:04:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20650 invoked by uid 89); 1 Aug 2018 04:04:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Aug 2018 04:04:11 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id E5D0A5D8EC for ; Tue, 31 Jul 2018 23:04:09 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id kiMrfjjAcPvAdkiMrfmJnc; Tue, 31 Jul 2018 23:04:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nZtZoqXpDSucveA79OqSY9ivg4leEmJrGZIu7VztpA8=; b=H7Eoyd8h8Uwl34p8cDwyzyXcCr Tl7b5Xz8mBZMrKlE9rMdSsgCyVAYbuyzYYmP7guvpWBRycTIn5WWrTOQNO/aAH+JmiKjDORLOdY0I +Z228gLGkRHWsQ2O6REFVohYw; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:37674 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fkiMr-001cTl-9L; Tue, 31 Jul 2018 23:04:09 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA_v4 1/8] Add helper functions parse_flags and parse_flags_qcs References: <20180710213926.32240-1-philippe.waroquiers@skynet.be> <20180710213926.32240-2-philippe.waroquiers@skynet.be> <20180730201556.GA19069@adacore.com> <87pnz4o2iu.fsf@tromey.com> <20180731135242.GA3186@adacore.com> <87va8v4dmy.fsf@tromey.com> <1533071582.1467.21.camel@skynet.be> Date: Wed, 01 Aug 2018 04:04:00 -0000 In-Reply-To: <1533071582.1467.21.camel@skynet.be> (Philippe Waroquiers's message of "Tue, 31 Jul 2018 23:13:02 +0200") Message-ID: <87zhy6n35z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00010.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> I am wondering if the correct solution would not be to avoid Philippe> having input lines memory being managed 'manually' like it is now, Philippe> as having the 'input const char* arg' disappearing 'under the carpet' Philippe> is quite tricky, and we might have other places where a previous Philippe> line of input must be kept alive, while new lines of input have Philippe> to be read. Yeah, my approach has been to require the callers of handle_line_of_input to handle the storage, so nothing relies on saved_command_line surviving across reentrant calls. Thanks for pointing out that other regression. I don't think I was aware of that one. Tom