From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25881 invoked by alias); 17 Sep 2018 06:37:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25867 invoked by uid 89); 17 Sep 2018 06:37:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 06:37:49 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id E503D400D4969 for ; Mon, 17 Sep 2018 01:37:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1n9zg3wuMSjJA1nABgfMMV; Mon, 17 Sep 2018 01:37:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+XC0Ozyywxe1lF0uKFQkeInZtrXOBvJaZMBjNFAao6k=; b=GZ2xizQCMTN5OU0jOJvdATB4zC fnnF2Qv3nLponIZiI9bprBKfz4yJdniuj/0ldbXRdzjhzByA3j8V6Q1QdTEBGIy5KeUPl4bO9lW0j fDTrXHSmiyVzKKt4f4lUQDjPn; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49322 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1n9z-003PCu-E5; Mon, 17 Sep 2018 01:37:27 -0500 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] python: Make gdb.execute("show commands") work (PR 23669) References: <20180917012350.10194-1-simon.marchi@polymtl.ca> Date: Mon, 17 Sep 2018 06:37:00 -0000 In-Reply-To: <20180917012350.10194-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 16 Sep 2018 21:23:50 -0400") Message-ID: <87zhwgmxy1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00561.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Since commit Simon> 56bcdbea2bed ("Let gdb.execute handle multi-line commands") Simon> trying to use a command like gdb.execute("show commands") in Python Simon> fails. GDB ends up trying to run the "commands" command. Simon> The reason is that GDB gets confused with the special "commands" Simon> command. In process_next_line, the lookup_cmd_1 function returns the Simon> cmd_list_element representing the "commands" sub-command of "show". Simon> Lower, we check the cmd_list_element to see if it matches various Simon> control commands by name, including the "commands" command. This is Simon> where we wrongfully conclude that the executed command must be Simon> "commands", when in reality it was "show commands". Simon> The fix proposed in this patch removes the comparisons by name, instead Simon> comparing the cmd_list_element object by pointer with the objects Simon> created at initialization time. Thanks for doing this. I think getting rid of command_name_equals is a nice cleanup. The patch looks good to me. Tom