Re: [PATCH v2] Avoid crash when calling warning too early

Pedro Alves
2018-11-09T19:41:42Z

On 10/31/2018 06:18 PM, Tom Tromey wrote:
> +set save $INTERNAL_GDBFLAGS
> +set INTERNAL_GDBFLAGS "-nw -nx -data-directory $tname"
> +
> +gdb_start
> +
> +# Make sure gdb started up.
> +gdb_test "echo 23\\n" "23"

I guess this could also check that the warning was emitted?

> +
> +set INTERNAL_GDBFLAGS $save

FYI, you can use:

save_vars { INTERNAL_GDBFLAGS } {
set INTERNAL_GDBFLAGS "-nw -nx -data-directory $tname"
...
}

But, note that gdb/testsuite/README says this about
INTERNAL_GDBFLAGS:

~~~
The testsuite does not override a value provided by the user.
~~~

I think that the test should instead be replacing/sed'ing
the existing -data-directory option, instead of overriding
INTERNAL_GDBFLAGS completely.
That's what gdb.base/gdbinit-history.exp does.

Thanks,
Pedro Alves