Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	 Keith Seitz <keiths@redhat.com>,
	 Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [RFC/PATCH] Fix dwarf2read.c:dwarf2_find_containing_comp_unit's binary search
Date: Fri, 30 Nov 2018 18:05:00 -0000	[thread overview]
Message-ID: <87zhtqqw3p.fsf@redhat.com> (raw)
In-Reply-To: <87ftvi1mi3.fsf@tromey.com> (Tom Tromey's message of "Fri, 30 Nov	2018 10:52:20 -0700")

On Friday, November 30 2018, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> 	https://bugzilla.redhat.com/show_bug.cgi?id=1613614
> Sergio> 	* dwarf2read.c (dwarf2_find_containing_comp_unit): Add
> Sergio> 	'mid_cu->length' to '*cu_off' when checking if 'sect_off' is
> Sergio> 	inside the CU.
>
> Thanks for the extensive analysis.
> I agree this is correct; please check this in.

Thanks for the quick review.  This has been pushed:

81fbbaf96216ed88973a069e4ed25379d7421ec8

> It's weird that cu_off is a pointer in this code.
> It seems like that local could be removed entirely.
> But, no need to do that in this patch.

Yeah, as I told you on IRC, I also noticed this.  I'll see about sending
a subsequent patch later.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  reply	other threads:[~2018-11-30 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 17:22 Sergio Durigan Junior
2018-11-30 17:52 ` Tom Tromey
2018-11-30 18:05   ` Sergio Durigan Junior [this message]
2018-12-04 16:44     ` Keith Seitz
2018-12-04 16:50       ` Sergio Durigan Junior
2018-12-16 16:44         ` Tom Tromey
2018-12-18 15:48           ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhtqqw3p.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=keiths@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox