Re: [PATCH 00/16] Add styling to the gdb CLI and TUI

Joel Brobecker
2018-12-24T09:27:46Z

> This patch series adds terminal styling (colorizing) to gdb's CLI and
> TUI. It is a refresh of an earlier RFC series, but some parts have
> changed, and now there are tests and documentation. It also includes
> some TUI colorizing patches that were sent separately.
>
> This series doesn't support the Windows console. I don't know
> anything about it. So, it defaults to disabling styling on Windows
> hosts. This could be fixed by doing something like what the TUI does:
> filter escape sequences from the output and apply them by some other
> means.
>
> More styling could be done. It's relatively easy to add a new
> style-able object.
>
> If you want to try this out, it is the branch "submit/colorize" in my
> github repository.
>
> Regression tested on x86-64 Fedora 28. I think it was too big for the
> buildbot.

I gave the whole series a look. The TUI changes were a bit alien
to me. I sent comments on the patches where I had questions;
otherwise, those I didn't comment on looked fine to me.

I really look forward to this series making it to master, it would
be a nice feature to advertise on the release that includes it.
The source highlighting is also a very nice touch!

One feature I might volunteer to work on once the series is in
is to provide two sets of defaults for the colors - one to be used
when the terminal has a dark background vs one to be used when
the terminal has a light background. I think the way ou added
colorizing should make it easy to do.

That's all I had to say as a summary. Thanks a lot for those.
I think people are going to enjoy this enchancement. At least
I know I will!

--
Joel