Re: [PATCH 00/16] Add styling to the gdb CLI and TUI

Pedro Alves
2019-03-01T14:10:05Z

On 03/01/2019 01:56 PM, Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>

>> Basically, GDB needs to call SetConsoleMode with
>> ENABLE_VIRTUAL_TERMINAL_PROCESSING at early startup to enable the feature.
>> There's an example at the bottom of page [1] above.
>>
>> I have no idea whether that interacts badly with readline or curses, but
>> it seems like the ideal solution going forward.
>
> We don't want to require Windows 10 for the styling support, do we?
> Older versions of Windows still have quite a few years before they are
> unsupported even by Microsoft, let alone GDB.

I'm saying that there's an easy way out that likely
gets you styling without much work. Over time, older versions of
Windows will fade away. I'm comparing to the current state, where
there's no styling at all.

> Or are you saying that you will be unwilling to accept patches that
> enable styling on all versions of Windows (by converting SGR sequences
> to corresponding Windows API calls)?

Of course not. If someone's willing to implement that, it's super
fine with me. It's not unlike what Tom did for TUI / curses.

Thanks,
Pedro Alves