Re: [PATCH 00/16] Add styling to the gdb CLI and TUI

Tom Tromey
2018-12-28T20:57:19Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I gave the whole series a look. The TUI changes were a bit alien
Joel> to me. I sent comments on the patches where I had questions;
Joel> otherwise, those I didn't comment on looked fine to me.

Thanks for the reviews!

Joel> One feature I might volunteer to work on once the series is in
Joel> is to provide two sets of defaults for the colors - one to be used
Joel> when the terminal has a dark background vs one to be used when
Joel> the terminal has a light background. I think the way ou added
Joel> colorizing should make it easy to do.

This sounds like a good idea, and we can certainly tinker with it as
need be.

I have a few patches to GNU Source Highlight that I am trying to get in.
I have some updates for the C and C++ support, plus Rust support. The
project seems a bit dead so I've asked maintainers@gnu to give me
permissions to check in some patches and do a new release.

Joel> That's all I had to say as a summary. Thanks a lot for those.
Joel> I think people are going to enjoy this enchancement. At least
Joel> I know I will!

Thanks. I am going to check in the series now.

Tom