Re: GDB version as convenience variable

Eli Zaretskii
2019-03-25T18:10:21Z

> From: Simon Marchi <simark@simark.ca>
> Date: Mon, 25 Mar 2019 13:58:20 -0400
>
> > +@item $_gdb_major
> > +@itemx $_gdb_minor
> > +@vindex $_gdb_major@{, convenience variable}
> > +@vindex $_gdb_minor@{, convenience variable}
> > +The major and minor version numbers of the running @value{GDBN}.
> > +Development snapshots and pretest versions have their minor version
> > +incremented by one; thus, @value{GDBN} pretest 9.11.90 will produce
> > +the value 12 for @code{$_gdb_minor}. These variables allow you to
> > +write scripts that work with different versions of @value{GDBN}
> > +without errors caused by features unavailable in some of those
> > +versions.
> > @end table
>
> I get this error when trying to "make html":
>
> /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11216: misplaced }
> /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11217: misplaced }

Thanks, fixed. Too many r's...

> Is it worth having a test for that?

Hmm... how would you test that?

> If we check that they have the expected value, it would be something
> to change when a new GDB branch is created, probably (as the master
> branch will now represent the next version). Maybe our release
> manager should have a say in this :).

I'm all ears.

> Otherwise, this LGTM.

Thanks for the review.