From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103961 invoked by alias); 10 Jul 2019 17:03:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103939 invoked by uid 89); 10 Jul 2019 17:03:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 17:03:53 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 0BF985973 for ; Wed, 10 Jul 2019 12:03:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id lG0VhBPqW2PzOlG0VhMRZq; Wed, 10 Jul 2019 12:03:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ENFM2GlK0Gr0uNzsICQn1EOVckhwyLZEVExZR36ujTY=; b=RFJPKN+XnHk0EcV8c9zoSogvxX 53oj/+F5qOuo0rb0CzmEolitmgwNBwMSlYmNuWmzpB82ZMa4/WvkjaPJpCRAFFTFLlVx9FfDTCZDv c42DJkza5azxDlZ4OtKRGCjiw; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:50880 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hlG0V-001HVJ-Gu; Wed, 10 Jul 2019 12:03:51 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Change remote-sim.c to use type-safe registry References: <20190710153947.25721-1-tromey@adacore.com> <20190710153947.25721-2-tromey@adacore.com> <1c14cf2e-6cef-3f3a-39dc-2cc3cae23e88@simark.ca> Date: Wed, 10 Jul 2019 17:03:00 -0000 In-Reply-To: <1c14cf2e-6cef-3f3a-39dc-2cc3cae23e88@simark.ca> (Simon Marchi's message of "Wed, 10 Jul 2019 12:59:14 -0400") Message-ID: <87zhlles95.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00270.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> It probably doesn't matter because it's reassigned after sim_inferior_data, Simon> is allocated, but this field should probably be initialized too, to be consistent Simon> with the other fields. ptid_t doesn't initialize its fields by default (to remain Simon> a POD), so its initial content would be some garbage. Thanks for catching that. I forgot about this aspect of ptid_t. I've made the change locally. Tom