From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116861 invoked by alias); 30 Sep 2019 14:28:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116851 invoked by uid 89); 30 Sep 2019 14:28:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=safest, shorter X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.46.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Sep 2019 14:28:17 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 7E6214015221D for ; Mon, 30 Sep 2019 09:28:16 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EweuigbpNW4frEweuiNRM4; Mon, 30 Sep 2019 09:28:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cvRSGGfscrQCWzhOVF0O0pI+dw2GhZPH4lRArGxgP4c=; b=DIljX31lqT8yuIFienPEmcnui3 lHJNtyZYrKL/uXY2KXUwXPII6z19BSYrBkXFUR9CqaM8z3OEuJCA0sICDAtX6rfkOjWWS5J5scx00 qC61HTc5MEPE05ANEY5aWtUGI; Received: from 75-166-72-156.hlrn.qwest.net ([75.166.72.156]:34064 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iEweu-0013Hj-4b; Mon, 30 Sep 2019 08:28:16 -0600 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Change some arguments to gdb::string_view instead of name+len References: <20190929053440.144834-1-cbiesinger@google.com> Date: Mon, 30 Sep 2019 14:28:00 -0000 In-Reply-To: <20190929053440.144834-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Sun, 29 Sep 2019 00:34:40 -0500") Message-ID: <87zhilamf5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00612.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> Just some code cleanup. This change has a few benefits: Christian> - Shorter argument list in the functions Christian> - If the caller needs to calculate the string, they no longer Christian> need to explicitly call strlen Christian> - It is easy to pass std::string to this (done in one place Christian> currently) Christian> This also updates a couple of places that were passing 0/1 to Christian> a bool parameter. Thanks for doing this. I think it is a nice cleanup. Christian> -minimal_symbol_reader::record_full (const char *name, int name_len, [...] Christian> if (name[0] == get_symbol_leading_char (m_objfile->obfd)) Christian> { Christian> - ++name; Christian> - --name_len; Christian> + name = gdb::string_view (name.data() + 1, name.length () - 1); This could probably use the substr method. Christian> if (symtab_create_debug >= 2) Christian> printf_unfiltered ("Recording minsym: %-21s %18s %4d %s\n", Christian> - mst_str (ms_type), hex_string (address), section, name); Christian> + mst_str (ms_type), hex_string (address), section, Christian> + name.data ()); This part made me hesitate a bit, because it seems to be at odds with the idea that an arbitrary string view can be passed in -- for all we know the string isn't \0-terminated, and this will cause bad behavior. On the other hand, this error already existed, and is only used for logging. Maybe safest is just to transform it to a std::string here? Tom