Re: New ARI warning Wed Oct 2 01:56:22 UTC 2019

Eli Zaretskii
2019-10-02T17:02:06Z

> From: Tom Tromey <tromey@adacore.com>
> Cc: GDB Administrator <gdbadmin@sourceware.org>, gdb-patches@sourceware.org
> Date: Wed, 02 Oct 2019 10:15:05 -0600
>
> >>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> >>> gdb/valprint.c:2077: code: %p: Do not use printf(%p), instead use printf(%s,paddr()) to dump a target address, or host_address_to_string() for a host address
> >> gdb/valprint.c:2077: fprintf_filtered (stream, " %p[<repeats %u times>%p]",
> >>
>
> Simon> Hmm, I think we can get rid of that %p rule (or improve it),
> Simon> otherwise we will have a lot of noise.
>
> How's this?
>
> Tom
>
> commit ce98317860cdcdb19426ddee3509ccceea79c7b1
> Author: Tom Tromey <tromey@adacore.com>
> Date: Wed Oct 2 10:13:33 2019 -0600
>
> Let ARI allow gdb %p printf extensions
>
> As pointed out by Simon, this changes ARI to allow the gdb-specific %p
> printf extensions.

But %p is really not quite portable. For starters, on some systems it
includes the 0x prefix, on others it doesn't.