From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98552 invoked by alias); 13 Dec 2019 21:01:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98535 invoked by uid 89); 13 Dec 2019 21:01:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.184.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 21:01:39 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 2C3C97DE1 for ; Fri, 13 Dec 2019 15:01:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fs48iknDsHunhfs48i1YHJ; Fri, 13 Dec 2019 15:01:37 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DjdcxpE4Vozw3KESipQugKRf2xSe8sI+yAKFeLsAYtU=; b=au85VVNHBkk/zwxDqSRPwmsVH2 ROBM2R2BUWw2wDnXEXy0RzFn5Nc50+ypZpjb9lgCfnFH1dXMQid3V8IhwggCA1wfqbi3+N5q/WAqa sprDxoAmwBmFMy6WS3YSpvbiH; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:54952 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ifs48-002ZBL-Og; Fri, 13 Dec 2019 14:01:36 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] jit: c++-ify gdb_symtab References: <20191213060323.1799590-1-simon.marchi@polymtl.ca> <20191213060323.1799590-4-simon.marchi@polymtl.ca> Date: Fri, 13 Dec 2019 21:01:00 -0000 In-Reply-To: <20191213060323.1799590-4-simon.marchi@polymtl.ca> (Simon Marchi's message of "Fri, 13 Dec 2019 01:03:19 -0500") Message-ID: <87zhfwuehb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00612.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> + gdb_symtab (const char *file_name) Simon> + : file_name (file_name != nullptr ? file_name : "") Simon> + {} This should probably be "explicit". Tom