From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.51.6]) by sourceware.org (Postfix) with ESMTPS id 7C5433938C28 for ; Tue, 19 May 2020 14:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C5433938C28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id C59DB400D2B71 for ; Tue, 19 May 2020 08:37:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b3exjJ4ifXVkQb3exjOur0; Tue, 19 May 2020 09:55:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5uKbp+Wc7RXU6gn+cb/W7EE2r9VCbiYAQBmcwnPzaqM=; b=amWAp16Qzk5bbzfiU130nmttus IjEola/T2m5TppRNW9dpy3IdXGJNk6MpnKOFxOEyKjhwhvQ2LDv2klvJWMYKn8ielBJj5UPiWa0+A eawrsmH3IrU+Vn6FW4uBWoN2J; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:52512 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jb3ew-001pwX-OH; Tue, 19 May 2020 08:55:58 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 2/3] gdb: use std::vector to store segments in symfile_segment_data References: <20200519013533.1428830-1-simon.marchi@efficios.com> <20200519013533.1428830-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 19 May 2020 08:55:57 -0600 In-Reply-To: <20200519013533.1428830-3-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 18 May 2020 21:35:32 -0400") Message-ID: <87zha47z42.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jb3ew-001pwX-OH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:52512 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 14:56:00 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> symfile_segment_data_up data (new symfile_segment_data); Simon> - data->num_segments = num_segments; Simon> - data->segment_bases = XCNEWVEC (CORE_ADDR, num_segments); Simon> - data->segment_sizes = XCNEWVEC (CORE_ADDR, num_segments); Simon> for (i = 0; i < num_segments; i++) Simon> - { Simon> - data->segment_bases[i] = segments[i]->p_vaddr; Simon> - data->segment_sizes[i] = segments[i]->p_memsz; Simon> - } Simon> + data->segments.emplace_back (segments[i]->p_vaddr, segments[i]->p_memsz); It's probably better to just resize() to the desired size, instead of using emplace_back. That may save some memory, because it won't over-allocate. Probably not super important, but at the same time easy to do. Tom