From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.184.18]) by sourceware.org (Postfix) with ESMTPS id C8D18385E830 for ; Fri, 22 May 2020 20:31:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C8D18385E830 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id A679F4010AC31 for ; Fri, 22 May 2020 14:51:11 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cEKLjj6pF8vkBcEKLjOMgx; Fri, 22 May 2020 15:31:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ftdVeq54hEuyT5x05XPAdB06nZqmqLce6TRAePTsKgs=; b=gKjzORy2CqlrcP8lZtZVxcKgVX u2zp5tLcmUeE/UDtuI/Tii8QsDnWMYc7oTp9AzMakjV4YJOK2T4Mlyurp/YqsX8ik9NiQh6wwfs7G QtGZ3zbhG7mHQoXAZytlaYH2I; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36136 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcEKL-003w35-FT; Fri, 22 May 2020 14:31:33 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/symtab] Handle .gdb_index in ada language mode References: <20200513094147.GA20499@delia> <87tv0b64yd.fsf@tromey.com> <89719b8a-9252-7af5-3ad8-1bcd1ebbc80c@suse.de> X-Attribution: Tom Date: Fri, 22 May 2020 14:31:32 -0600 In-Reply-To: <89719b8a-9252-7af5-3ad8-1bcd1ebbc80c@suse.de> (Tom de Vries's message of "Wed, 20 May 2020 11:40:21 +0200") Message-ID: <87zh9z1zkr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcEKL-003w35-FT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36136 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 20:31:38 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> Using this patch, I managed to get it working. Wow, cool. Tom> The patch does the following: Tom> - enable ada .gdb_index by removing the ada check in write_psymbols Tom> - copy some ada-specific code from debug_names::insert to Tom> write_psymbols Tom> - disable a workaround for gold/15646 in dw2_expand_marked_cus Tom> As for the disabled workaround, I ran into trouble in Tom> gdb.ada/access_tagged_param.exp, where setting a breakpoint on foo failed. Tom> The index shows that there are two entries for foo, one variable, one Tom> function: Tom> ... Tom> [3733] foo: Tom> 3 [global, variable] Tom> 5 [global, function] Tom> ... Tom> The workaround skips the function, so disabling the workaround allows Tom> the test to pass (my guess atm is that the workaround is not precise Tom> enough). Looking at the gold bug, I suspect what's needed is to rule out duplicates that have the same kind. I tend to think you should push your previous patch, and maybe we can revisit this stuff later. Tom> + std::string decoded = ada_decode (name); Tom> + if (decoded[0] == '<') Tom> + name = (char *) strndup (decoded.c_str () + 1, decoded.length () - 2); Tom> + else Tom> + name = strdup (ada_encode (decoded.c_str ())); Tom> + } This leaks the string. Tom