From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.46]) by sourceware.org (Postfix) with ESMTPS id 8AD363858D35 for ; Tue, 30 Jun 2020 20:47:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AD363858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id F20FE2044F for ; Tue, 30 Jun 2020 15:47:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qNAOjOmAuQyTQqNAOjVZJy; Tue, 30 Jun 2020 15:47:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kxo/0SsEclz98qyBx1uo2vhvBTVSz09fPLxoQhW6aTs=; b=SwzD4fMWWhdpS2r7FnAeAkR0mW lx3/EoRlQoxOHw59o1tYqvh4IzSyr47X5MTn/IYfoGC4lrOKqrktfWCXgqDz2W+nqfuzzQ1ZSjyNS M9CO3H9TmucJrZWKMMbiXiots; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:45850 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jqNAO-0048bY-Jn; Tue, 30 Jun 2020 14:47:44 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Simon Marchi Subject: Re: [PATCH 1/3] gdb: remove callback in macro expand functions References: <20200628165628.96730-1-simon.marchi@polymtl.ca> <20200628165628.96730-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 30 Jun 2020 14:47:43 -0600 In-Reply-To: <20200628165628.96730-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Sun, 28 Jun 2020 12:56:26 -0400") Message-ID: <87zh8k8emo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jqNAO-0048bY-Jn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:45850 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 20:47:47 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> From: Simon Marchi Simon> I started to look into changing the callbacks in macroexp.h to use Simon> gdb::function_view. However, I noticed that the passed lookup function Simon> was always `standard_macro_lookup`, which looks up a macro in a Simon> `macro_scope` object. Since that doesn't look like a very useful Simon> abstraction, it would be simpler to just pass the scope around and have Simon> the various functions call standard_macro_lookup themselves. This is Simon> what this patch does. This seems fine to me. I don't remember, but maybe this lookup function used to vary at some point in the past. That would explain the abstraction anyway. Or maybe it was just planned somehow. Tom