From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id B8cECsgum1/2EgAAWB0awg (envelope-from ) for ; Thu, 29 Oct 2020 17:06:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 1BFF91EFC1; Thu, 29 Oct 2020 17:06:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A3BC1E552 for ; Thu, 29 Oct 2020 17:06:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C90583854825; Thu, 29 Oct 2020 21:06:14 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.231]) by sourceware.org (Postfix) with ESMTPS id 720F73857C77 for ; Thu, 29 Oct 2020 21:06:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 720F73857C77 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 801405F090 for ; Thu, 29 Oct 2020 16:06:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YF7UkrByhnPrxYF7UkWsdX; Thu, 29 Oct 2020 16:06:04 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=apyiEA2ByxQpKVM8WNrOPhL0EOyy4/nRlC0+guJhc64=; b=QOeR+dSRwcMxgUSFUiHx6RRzvt gAiLoL7hc3HDYwLl3dFmIcWW0QiBsKR+n0wOBtNmXZQtrCksIQhi6dxLoHD2azyZoy4eaGh6RQfdb heo+mJIPWh0w55NtyxHawTHI0; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:60718 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kYF7U-002O5f-5n; Thu, 29 Oct 2020 15:06:04 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PP?] [PATCH v2 00/16] Remove some macros from exec.h and progspace.h References: <20201019214429.13815-1-tom@tromey.com> X-Attribution: Tom Date: Thu, 29 Oct 2020 15:06:02 -0600 In-Reply-To: (Simon Marchi's message of "Tue, 20 Oct 2020 10:46:02 -0400") Message-ID: <87zh4491z9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kYF7U-002O5f-5n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (bapiya) [97.122.89.243]:60718 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Simon> I sent a few minor comments, other than that it all LGTM. Thanks a lot Simon> for doing this, I think it really helps untangle this code. I'm checking this in now. I think I fixed all the comments and I re-regression tested it on x86-64 Fedora 28. I made a note to write a follow-up patch to move the method implementations to progspace.c. Tom