From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cXaZIDULJGGUPAAAWB0awg (envelope-from ) for ; Mon, 23 Aug 2021 16:55:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 72B471EE18; Mon, 23 Aug 2021 16:55:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B66491E813 for ; Mon, 23 Aug 2021 16:55:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13502385742E for ; Mon, 23 Aug 2021 20:55:16 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.161]) by sourceware.org (Postfix) with ESMTPS id 012763858D39 for ; Mon, 23 Aug 2021 20:54:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 012763858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 887A91F7EA7 for ; Mon, 23 Aug 2021 15:54:54 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id IGy6mO8THjSwzIGy6mjsTx; Mon, 23 Aug 2021 15:54:54 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Vht/sKI8wqOHgHZiL+yHpVoUtnGXSva5ycKwigWx4EU=; b=LLsiGmjkRwsH36AzSw7wccpxi6 UMZtkqv52TfrtFlK1X6fQMANJQahm6FOIvTGNthAhYaG+XZk+ynXJps1kXLh0qR0rH4v2O2rYV6+j ZhkmkB74HkJPzDUbTupCAa+O/; Received: from 97-122-86-84.hlrn.qwest.net ([97.122.86.84]:36900 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mIGy6-000mVp-3I; Mon, 23 Aug 2021 14:54:54 -0600 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 1/1] gdb: Fix arrays of variable length strings for FORTRAN References: <20210820110638.26648-1-abdul.b.ijaz@intel.com> <20210820110638.26648-2-abdul.b.ijaz@intel.com> <20210820155247.GA2581@embecosm.com> X-Attribution: Tom Date: Mon, 23 Aug 2021 14:54:53 -0600 In-Reply-To: <20210820155247.GA2581@embecosm.com> (Andrew Burgess's message of "Fri, 20 Aug 2021 16:52:47 +0100") Message-ID: <87zgt7990i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.84 X-Source-L: No X-Exim-ID: 1mIGy6-000mVp-3I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-84.hlrn.qwest.net (murgatroyd) [97.122.86.84]:36900 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: abdul.b.ijaz@intel.com, "abdul.b.ijaz" , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: >> case TYPE_CODE_ARRAY: >> + case TYPE_CODE_STRING: >> c_value_print_array (val, stream, recurse, options); >> break; Andrew> I don't understand what part this change plays in this patch. I can Andrew> see below how you're now creating values with TYPE_CODE_STRING instead Andrew> of TYPE_CODE_ARRAY, but then I'd expect these to be covered by the Andrew> existing handling of TYPE_CODE_STRING in Andrew> f_language::value_print_inner. I wonder if this should go in generic_value_print instead. Tom