From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6KNINTA4VmE/ZwAAWB0awg (envelope-from ) for ; Thu, 30 Sep 2021 18:20:32 -0400 Received: by simark.ca (Postfix, from userid 112) id D84421EDDB; Thu, 30 Sep 2021 18:20:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 43C4C1E4A3 for ; Thu, 30 Sep 2021 18:20:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB2C73857C62 for ; Thu, 30 Sep 2021 22:20:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB2C73857C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633040431; bh=jAmaYrOhtFxlIO/KE3IixBeeXQ5eDArhkWLQ5ZhgU+0=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ykA77w5DPYPirhSoEs/E/WiB2QNmcNif4QeVPz2SdXb69P/NXeT/0vmG1FuYgBtPx tS4QKhlTZVuGib3VrB4SDdulJiPucD50l93fFznx4d8YmS8W7I7ZbTXSKi/rgduJDd 59ALjj1PkcAHBhLmaoVm7ohhkTNqAXJC39VAKGns= Received: from mail.sergiodj.net (mail.sergiodj.net [167.114.15.217]) by sourceware.org (Postfix) with ESMTPS id 3AA0E3858C39 for ; Thu, 30 Sep 2021 22:20:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AA0E3858C39 Received: from localhost (bras-base-toroon1016w-grc-45-76-65-26-78.dsl.bell.ca [76.65.26.78]) by mail.sergiodj.net (Postfix) with ESMTPSA id 9ECB8A01B1; Thu, 30 Sep 2021 18:20:11 -0400 (EDT) To: Tom Tromey Subject: Re: [PATCH] [PR gdb/28369] Use get_shell on gdb/ser-pipe.c References: <20210925213421.750832-1-sergiodj@sergiodj.net> <87h7e20xni.fsf@tromey.com> X-URL: http://blog.sergiodj.net Date: Thu, 30 Sep 2021 18:20:11 -0400 In-Reply-To: <87h7e20xni.fsf@tromey.com> (Tom Tromey's message of "Thu, 30 Sep 2021 11:40:49 -0600") Message-ID: <87zgrtbt9g.fsf@paluero> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergio Durigan Junior via Gdb-patches Reply-To: Sergio Durigan Junior Cc: Sergio Durigan Junior via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thursday, September 30 2021, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior via Gdb-patches writes: > > Sergio> PR gdb/28369 reports that gdb/ser-pipe.c has an 'execl' function call > Sergio> with a hard-coded "/bin/sh" as its argument. We've had 'get_shell' > Sergio> for a while now, which is conscious about the SHELL environment and a > Sergio> better alternative to always calling "/bin/sh". > > Thanks, this is ok. Thanks, Tom. Pushed: 906e2b7664c5becfa3e10717a7d530e87fdab4ec -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/