From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gf2eG+Cme2LPoAUAWB0awg (envelope-from ) for ; Wed, 11 May 2022 08:06:56 -0400 Received: by simark.ca (Postfix, from userid 112) id 641331E21F; Wed, 11 May 2022 08:06:56 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=CWMWr6mz; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B289C1E00D for ; Wed, 11 May 2022 08:06:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4227385E010 for ; Wed, 11 May 2022 12:06:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4227385E010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652270814; bh=eOObqIQOHDU0j81mL6WjdnN45YBNEi2ROzvcJsj+1BA=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CWMWr6mzEcVJz/xLsP2jZTF5UmWmaaW4lrvYPD1yV1cw0VJ1/HAdNAq+kzkKItnMj RTNa/Oog/ZKWShXvqBgCKelY2YxoTC6SITaxFe25uJNj82PzRNEvK49TOcEzoLBpjf vHCmNvlZpJbtkyiokWuA//SL8QjrxabQVDDFmSKM= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1789F3858CDA for ; Wed, 11 May 2022 12:06:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1789F3858CDA Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-436-XiY95XzbNFyn7tsmAUEzsg-1; Wed, 11 May 2022 08:06:31 -0400 X-MC-Unique: XiY95XzbNFyn7tsmAUEzsg-1 Received: by mail-wm1-f70.google.com with SMTP id n186-20020a1c27c3000000b00392ae974ca1so1448094wmn.0 for ; Wed, 11 May 2022 05:06:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=eOObqIQOHDU0j81mL6WjdnN45YBNEi2ROzvcJsj+1BA=; b=7n2z02IcPo96WZYcnF6SZKyGARqY4RecRbcXYf/NOOKkbrG4Qtzu1OOEKQJIkKo39g +S9ePUsCgkOmvBKdbBRNc+ONMzwr+pCpSNVo0iXdDD2uj7zzugt9tFB/jd8/IFiFMQlg Agu+h1nwwX1AyMn3xB8TxwrblWu+XKkrHXUOpjg71ZaivThfUdM2+aM6f2lMPTiOxwYi gQjMuPCiRIQ6bVMxTWuA/Y5RhiEhf1U9I9tToyvD8Pr9FsVIx0I9AF/OMqtmILsCfzmA 5bAcxLwM/ILroVB3xM7vsvae7XVsGQLaOpFYceMFaPnlM2nlRAYNdu2n/mRF6suuZD92 pv2Q== X-Gm-Message-State: AOAM533X+ATsCvlKRuTVg1Bu0dufi2qjgAs7DlFetUJR20sT2mMuK+hL +RV0ovZXJoo49R8oeIsnjRuksK/A9V2+QbVuF3mayctdcehoThJWUCttNB7vxywa/Wix704Hzas 51eFZ0/ArIvyF0ib8tza7oQ== X-Received: by 2002:a7b:cc8e:0:b0:393:fbf9:ab72 with SMTP id p14-20020a7bcc8e000000b00393fbf9ab72mr4487837wma.70.1652270789818; Wed, 11 May 2022 05:06:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmKkrttqBJMGcRIFrnsGxDMSDS94+XN/HR0o12goAWPQZFWykJeqyJJQFgE6e2rjPhKrovDg== X-Received: by 2002:a7b:cc8e:0:b0:393:fbf9:ab72 with SMTP id p14-20020a7bcc8e000000b00393fbf9ab72mr4487815wma.70.1652270789550; Wed, 11 May 2022 05:06:29 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id i6-20020a05600c354600b003942a244f33sm5800487wmq.12.2022.05.11.05.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 05:06:28 -0700 (PDT) To: Nils-Christian Kempke , gdb-patches@sourceware.org Subject: Re: [PATCH 13/18] testsuite, fortran: fix info-types for intel compilers In-Reply-To: <20220510142437.1397399-14-nils-christian.kempke@intel.com> References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-14-nils-christian.kempke@intel.com> Date: Wed, 11 May 2022 13:06:27 +0100 Message-ID: <87zgjojmt8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: JiniSusan.George@amd.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Nils-Christian Kempke writes: > First, the emitted symbol character*1 which is checked in the test > is not even referenced as a type in the compiled examples. It seems > to be a gfortran specific check for some type that gets emitted always. > I changed the test to use check_optional_entry here to allow the > symbol's absence. > > Second, the line checked for s1 was hardcoded in the test. Given that > the type is actually defined on line 41 (which is what is emitted by > ifx) it even seems wrong. I changed the line check for s1 to actually > check for 41 and a gfortran bug has been filed here > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105454 > > The test is now marked as xfail for gfortran. > > Third, the test was checking for s1 to be emitted by info types. This > would mean that the type is put into compilation unit scope in the DWARF > but, as it is local to the main program this is actually not expected > and gfortran specific. > Since I already added the xfail for gfortran here, I opted to also make > this check gfortran specific. > --- > gdb/testsuite/gdb.fortran/info-types.exp | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.fortran/info-types.exp b/gdb/testsuite/gdb.fortran/info-types.exp > index 67fe4d79c5..06770aada1 100644 > --- a/gdb/testsuite/gdb.fortran/info-types.exp > +++ b/gdb/testsuite/gdb.fortran/info-types.exp > @@ -41,12 +41,16 @@ set real4 [fortran_real4] > GDBInfoSymbols::run_command "info types" > GDBInfoSymbols::check_header "All defined types:" > > -GDBInfoSymbols::check_entry "${srcfile}" "" "${character1}" > +GDBInfoSymbols::check_optional_entry "${srcfile}" "" "${character1}" Could we not just add a reference to character*1 type? I'm happy to take this change, but just adding a use might make a stronger test? > GDBInfoSymbols::check_entry "${srcfile}" "" "${integer4}" > GDBInfoSymbols::check_entry "${srcfile}" "" "${logical4}" > GDBInfoSymbols::check_entry "${srcfile}" "$decimal" "Type m1t1;" > GDBInfoSymbols::check_entry "${srcfile}" "" "${real4}" > -GDBInfoSymbols::check_entry "${srcfile}" "37" "Type s1;" > + > +if { [test_compiler_info {gfortran-*} f90] } { > + setup_xfail *-*-* gcc/105454 > + GDBInfoSymbols::check_entry "${srcfile}" "41" "Type s1;" > +} Shouldn't the GDBInfoSymbols::check_entry call be outside of the if block? I think, with your change, the test will _only_ be run on gfortran, which is not what you wanted. Thanks, Andrew > > return 0 > > @@ -62,5 +66,5 @@ gdb_test "info types" \ > "(35:\[\t \]+Type __vtype_mod1_M1t1;" \ > ")?$decimal:\[\t \]+Type m1t1;" \ > "\[\t \]+${real4}" \ > - "37:\[\t \]+Type s1;(" \ > + "41:\[\t \]+Type s1;(" \ > ".*)?"] > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928