From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +lvhEw68vWKqkQkAWB0awg (envelope-from ) for ; Thu, 30 Jun 2022 11:06:54 -0400 Received: by simark.ca (Postfix, from userid 112) id 3A32B1E22B; Thu, 30 Jun 2022 11:06:54 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=UGQWS073; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CCE041E222 for ; Thu, 30 Jun 2022 11:06:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 557CD383F41F for ; Thu, 30 Jun 2022 15:06:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 557CD383F41F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1656601612; bh=ubUhOLZbFpiiyA0igGCZ/Up/BoraPnz7/BrFmtH2SUM=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UGQWS073Z6JuPfFF5u3wsny7UGxkQZU13zgq6KUu0FBBt5/pP63vKidCVeDuPyUQU k8nWiUKOb1TSGkkldQzSk6tcdTvdfdyB83IKzO64pLxrXa7rO40zc2zY12mVfZKiLY BrFXyTxMVdayraYTbahvSIsoSkeOfiwhtrXW7huE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 83B0438460AE for ; Thu, 30 Jun 2022 15:06:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83B0438460AE Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-_3LpbJRQNMm2mJjAsg9zHQ-1; Thu, 30 Jun 2022 11:06:32 -0400 X-MC-Unique: _3LpbJRQNMm2mJjAsg9zHQ-1 Received: by mail-wm1-f72.google.com with SMTP id o28-20020a05600c511c00b003a04f97f27aso1612394wms.9 for ; Thu, 30 Jun 2022 08:06:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=ubUhOLZbFpiiyA0igGCZ/Up/BoraPnz7/BrFmtH2SUM=; b=6HRM7TpI6oPjvhJ/u7Tf/jqQXI9mmjpj/okCH+Hhh+RaKYOKTximzqDhY8mqDY5Gse 1U73Am2i7XIE6TFXc5pY9vfR+uDsmtBzZZqyb0XZutEnWWhj2jmsNEYDzKQwRpKUgNDo HpTU+bBZ4HwbmDX01Lbd/otTf7gw9wuGM3uIb5a1JNfv2M7bIxic5bp+mB2PVoolYGHr 5TtLVEcCArmodfq1IuoDhBtgo8D7+L/JipHe/zNalmQbkVhLRnCDcAXABr1GpsvEuTnN azVaKUFlssZO1EG454q8EDf+K4DTsM5xowiUAQC5NFhj/JcjmdGZ6jVsVCPtRtCGpTDB RCiw== X-Gm-Message-State: AJIora8x0ylKxPJ9zvBAj2bT4btdO5QWP/U559gQMSCY6XmQRmczlCm8 zf8m0sWvjs8Dv7xULezBqLpC29acgxnyoMzJVD0qQXhdDIG3HHEV5DoND9lDi28++zjARrxHiKd EcJ+W/GrJIKY2AIj9bRh/WA== X-Received: by 2002:a05:600c:4e49:b0:3a0:4c17:c67f with SMTP id e9-20020a05600c4e4900b003a04c17c67fmr12851735wmq.1.1656601590530; Thu, 30 Jun 2022 08:06:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sGheK4Vczi5PscO1kqaW0KoHPneWwbJ99KM996AVKS1M92q22HTAovMD9BJMbeEr2XL5mjOg== X-Received: by 2002:a05:600c:4e49:b0:3a0:4c17:c67f with SMTP id e9-20020a05600c4e4900b003a04c17c67fmr12851716wmq.1.1656601590352; Thu, 30 Jun 2022 08:06:30 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id 18-20020a05600c269200b003a03a8475bfsm2800029wmt.16.2022.06.30.08.06.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 08:06:29 -0700 (PDT) To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH v3 06/14] fix gdb.base/access-mem-running.exp for clang testing In-Reply-To: <20220526151041.23223-7-blarsen@redhat.com> References: <20220526151041.23223-1-blarsen@redhat.com> <20220526151041.23223-7-blarsen@redhat.com> Date: Thu, 30 Jun 2022 16:06:28 +0100 Message-ID: <87zghub37v.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Bruno Larsen via Gdb-patches writes: > Clang was optimizing global_var away because it was not being used > anywhere. this commit fixes that by adding the attribute used it. LGTM. Thanks, Andrew > --- > > No change in v3. > > No change in v2. > > --- > gdb/testsuite/gdb.base/access-mem-running.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/access-mem-running.c b/gdb/testsuite/gdb.base/access-mem-running.c > index 6335f1bf199..cff6f0da820 100644 > --- a/gdb/testsuite/gdb.base/access-mem-running.c > +++ b/gdb/testsuite/gdb.base/access-mem-running.c > @@ -19,7 +19,7 @@ > > static unsigned int global_counter = 1; > > -static volatile unsigned int global_var = 123; > +static volatile unsigned int __attribute__((used)) global_var = 123; > > static void > maybe_stop_here () > -- > 2.31.1